shinseongsu commented on PR #943:
URL: 
https://github.com/apache/httpcomponents-client/pull/943#issuecomment-6964153802

   Thanks for merging!
   
   Regarding `ComplexFuture`, I don't see a clean way to fix it there. 
`setDependency(Cancellable)` can't tell whether the cancellable it gets has 
already completed, because `Cancellable` doesn't expose that. The `Future` 
overload could skip a dependency that is already done, but `acquireEndpoint` 
returns a plain `Cancellable`, so this path doesn't go through it. And making 
`setDependency` keep the existing dependency would break the normal lease, 
connect, execute hand-off. That's why I went with the holder at the call site.
   
   I'll send the TLS handshake cancel and the 
`MinimalHttpAsyncClient#leaseEndpoint` fixes as separate PRs.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to