> On Feb. 19, 2014, 10:28 a.m., Kishore Gopalakrishna wrote: > > helix-core/src/main/java/org/apache/helix/api/accessor/ClusterAccessor.java, > > line 60 > > <https://reviews.apache.org/r/17670/diff/1/?file=463474#file463474line60> > > > > Are we sacrificing the ability to plugin state store? The idea behind > > accessor was to hide ZK. Just getting paths for Cluster should be > > independent of Helix right? We should probably move this to HelixUtil ?
I agree. I can create a separate issue for moving these functions. - Kanak ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17670/#review34891 ----------------------------------------------------------- On Feb. 3, 2014, 11:25 a.m., Kanak Biscuitwala wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17670/ > ----------------------------------------------------------- > > (Updated Feb. 3, 2014, 11:25 a.m.) > > > Review request for helix, Zhen Zhang and Kishore Gopalakrishna. > > > Bugs: HELIX-360 > > > Repository: helix-git > > > Description > ------- > > commit 0d148843f4c55e255ac51160d9dfb2b3047eb3dd > Author: Kanak Biscuitwala <[email protected]> > Date: Mon Feb 3 11:21:55 2014 -0800 > > [HELIX-360] Remove code duplication for list of required paths > > :100644 100644 1c734e3... 90f58ea... M > helix-core/src/main/java/org/apache/helix/api/accessor/AtomicParticipantAccessor.java > :100644 100644 cda83d8... 48457b2... M > helix-core/src/main/java/org/apache/helix/api/accessor/AtomicResourceAccessor.java > :100644 100644 36c7aaa... abb3e49... M > helix-core/src/main/java/org/apache/helix/api/accessor/ClusterAccessor.java > :100644 100644 c3deafe... 3a34ca2... M > helix-core/src/main/java/org/apache/helix/api/accessor/ParticipantAccessor.java > :100644 100644 80c5b16... 73d43b0... M > helix-core/src/main/java/org/apache/helix/api/accessor/ResourceAccessor.java > :100644 100644 45fc355... b3252a8... M > helix-core/src/main/java/org/apache/helix/controller/stages/PersistAssignmentStage.java > :100644 100644 9018416... 30ee16c... M > helix-core/src/main/java/org/apache/helix/manager/zk/ZKUtil.java > :100644 100644 1bdc54c... d59fad7... M > helix-core/src/main/java/org/apache/helix/manager/zk/ZkHelixConnection.java > :100644 100644 ba8958d... ea28c76... M > helix-core/src/main/java/org/apache/helix/tools/NewClusterSetup.java > :100644 100644 4eebbc6... ee51834... M > helix-core/src/test/java/org/apache/helix/api/accessor/TestAccessorRecreate.java > > > Diffs > ----- > > > helix-core/src/main/java/org/apache/helix/api/accessor/AtomicParticipantAccessor.java > 1c734e3 > > helix-core/src/main/java/org/apache/helix/api/accessor/AtomicResourceAccessor.java > cda83d8 > helix-core/src/main/java/org/apache/helix/api/accessor/ClusterAccessor.java > 36c7aaa > > helix-core/src/main/java/org/apache/helix/api/accessor/ParticipantAccessor.java > c3deafe > > helix-core/src/main/java/org/apache/helix/api/accessor/ResourceAccessor.java > 80c5b16 > > helix-core/src/main/java/org/apache/helix/controller/stages/PersistAssignmentStage.java > 45fc355 > helix-core/src/main/java/org/apache/helix/manager/zk/ZKUtil.java 9018416 > helix-core/src/main/java/org/apache/helix/manager/zk/ZkHelixConnection.java > 1bdc54c > helix-core/src/main/java/org/apache/helix/tools/NewClusterSetup.java > ba8958d > > helix-core/src/test/java/org/apache/helix/api/accessor/TestAccessorRecreate.java > 4eebbc6 > > Diff: https://reviews.apache.org/r/17670/diff/ > > > Testing > ------- > > > Thanks, > > Kanak Biscuitwala > >
