> On Feb. 19, 2014, 6:39 p.m., Sandeep Nayak wrote: > > helix-core/src/main/java/org/apache/helix/api/accessor/AtomicParticipantAccessor.java, > > line 68 > > <https://reviews.apache.org/r/17670/diff/1/?file=463472#file463472line68> > > > > Why track the clusterId here if we are passing it in super? Please > > remove. > > Kanak Biscuitwala wrote: > We need it to acquire the locks at the appropriate scope inside the > overridden methods. So either we need a getter in the superclass or maintain > it as a member in this subclass.
A protected getter on the parent class would do the trick rather than keep duplicate data-set. - Sandeep ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17670/#review34893 ----------------------------------------------------------- On Feb. 19, 2014, 7:43 p.m., Kanak Biscuitwala wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17670/ > ----------------------------------------------------------- > > (Updated Feb. 19, 2014, 7:43 p.m.) > > > Review request for helix, Zhen Zhang and Kishore Gopalakrishna. > > > Bugs: HELIX-360 > > > Repository: helix-git > > > Description > ------- > > commit 0d148843f4c55e255ac51160d9dfb2b3047eb3dd > Author: Kanak Biscuitwala <[email protected]> > Date: Mon Feb 3 11:21:55 2014 -0800 > > [HELIX-360] Remove code duplication for list of required paths > > :100644 100644 1c734e3... 90f58ea... M > helix-core/src/main/java/org/apache/helix/api/accessor/AtomicParticipantAccessor.java > :100644 100644 cda83d8... 48457b2... M > helix-core/src/main/java/org/apache/helix/api/accessor/AtomicResourceAccessor.java > :100644 100644 36c7aaa... abb3e49... M > helix-core/src/main/java/org/apache/helix/api/accessor/ClusterAccessor.java > :100644 100644 c3deafe... 3a34ca2... M > helix-core/src/main/java/org/apache/helix/api/accessor/ParticipantAccessor.java > :100644 100644 80c5b16... 73d43b0... M > helix-core/src/main/java/org/apache/helix/api/accessor/ResourceAccessor.java > :100644 100644 45fc355... b3252a8... M > helix-core/src/main/java/org/apache/helix/controller/stages/PersistAssignmentStage.java > :100644 100644 9018416... 30ee16c... M > helix-core/src/main/java/org/apache/helix/manager/zk/ZKUtil.java > :100644 100644 1bdc54c... d59fad7... M > helix-core/src/main/java/org/apache/helix/manager/zk/ZkHelixConnection.java > :100644 100644 ba8958d... ea28c76... M > helix-core/src/main/java/org/apache/helix/tools/NewClusterSetup.java > :100644 100644 4eebbc6... ee51834... M > helix-core/src/test/java/org/apache/helix/api/accessor/TestAccessorRecreate.java > > > Diffs > ----- > > > helix-core/src/main/java/org/apache/helix/api/accessor/AtomicParticipantAccessor.java > 90f58ea > helix-core/src/main/java/org/apache/helix/api/accessor/ClusterAccessor.java > abb3e49 > > helix-core/src/main/java/org/apache/helix/api/accessor/ParticipantAccessor.java > 3a34ca2 > helix-core/src/main/java/org/apache/helix/manager/zk/ZKUtil.java 30ee16c > helix-core/src/main/java/org/apache/helix/manager/zk/ZkHelixConnection.java > d59fad7 > helix-core/src/main/java/org/apache/helix/util/HelixUtil.java 82d7b6c > > Diff: https://reviews.apache.org/r/17670/diff/ > > > Testing > ------- > > > Thanks, > > Kanak Biscuitwala > >
