----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18455/#review35379 -----------------------------------------------------------
helix-core/src/main/java/org/apache/helix/monitoring/MonitoringClient.java <https://reviews.apache.org/r/18455/#comment65876> If you add it to the event it is a "uses" contract which does not break most users. If you add it to the send API its a "provides" contract which breaks most implementers. So I would suggest adding it to the event. helix-core/src/main/java/org/apache/helix/monitoring/MonitoringClient.java <https://reviews.apache.org/r/18455/#comment65877> Why change this to void? If there is a good enough reason then fix javadocs. Ideally its good for the user to know if the flush worked or not. helix-monitor-client/src/main/java/org/apache/helix/monitoring/RiemannMonitoringClient.java <https://reviews.apache.org/r/18455/#comment65879> This is being added to a collection should this not implement hashcode and equals? helix-monitor-client/src/main/java/org/apache/helix/monitoring/RiemannMonitoringClient.java <https://reviews.apache.org/r/18455/#comment65880> Why use a concurrentmap when we are not using any of the concurrency variants on the map? The code seems to be using synchronized methods to access the map. helix-monitor-client/src/main/java/org/apache/helix/monitoring/RiemannMonitoringClient.java <https://reviews.apache.org/r/18455/#comment65878> Can this not be tightened do we need to synchronize the whole method? helix-monitor-client/src/main/java/org/apache/helix/monitoring/RiemannMonitoringClient.java <https://reviews.apache.org/r/18455/#comment65881> Could host be empty? helix-monitor-server/src/main/java/org/apache/helix/monitoring/RiemannMonitoringServer.java <https://reviews.apache.org/r/18455/#comment65882> Shouldn't this be marked volatile? helix-monitor-server/src/main/java/org/apache/helix/monitoring/RiemannMonitoringServer.java <https://reviews.apache.org/r/18455/#comment65884> Why synchronize the whole method if the idea is to control creation of the files why not guard it with a semaphore? - Sandeep Nayak On Feb. 25, 2014, 6:01 a.m., Zhen Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18455/ > ----------------------------------------------------------- > > (Updated Feb. 25, 2014, 6:01 a.m.) > > > Review request for helix, Kanak Biscuitwala and Kishore Gopalakrishna. > > > Repository: helix-git > > > Description > ------- > > [HELIX-319] refactor MonitoringClient to accommodate distributed monitoring > server > > > Diffs > ----- > > helix-core/src/main/java/org/apache/helix/HelixAutoController.java fdab2a6 > helix-core/src/main/java/org/apache/helix/HelixController.java 098fd96 > helix-core/src/main/java/org/apache/helix/HelixManager.java 17c94e5 > > helix-core/src/main/java/org/apache/helix/manager/zk/HelixConnectionAdaptor.java > 65a192a > helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixManager.java > 83eba53 > > helix-core/src/main/java/org/apache/helix/manager/zk/ZkHelixAutoController.java > 3967ed9 > helix-core/src/main/java/org/apache/helix/manager/zk/ZkHelixController.java > 9da59b9 > > helix-core/src/main/java/org/apache/helix/manager/zk/ZkHelixLeaderElection.java > 3c5b3db > helix-core/src/main/java/org/apache/helix/monitoring/MonitoringClient.java > a794eab > helix-core/src/main/java/org/apache/helix/monitoring/MonitoringServer.java > 3168bb2 > helix-core/src/test/java/org/apache/helix/Mocks.java 87d4e68 > > helix-core/src/test/java/org/apache/helix/controller/stages/DummyClusterManager.java > e07f0b5 > > helix-core/src/test/java/org/apache/helix/participant/MockZKHelixManager.java > 0b8395e > > helix-monitor-client/src/main/java/org/apache/helix/monitoring/RiemannMonitoringClient.java > 20b0825 > > helix-monitor-server/src/main/java/org/apache/helix/monitoring/RiemannMonitoringServer.java > 36719aa > > helix-monitor-server/src/test/java/org/apache/helix/monitoring/BasicMonitoringTest.java > 6680f00 > > helix-monitor-server/src/test/java/org/apache/helix/monitoring/TestClientServerMonitoring.java > 8b7f839 > > Diff: https://reviews.apache.org/r/18455/diff/ > > > Testing > ------- > > > Thanks, > > Zhen Zhang > >
