> On Feb. 25, 2014, 12:59 a.m., Sandeep Nayak wrote: > > helix-monitor-client/src/main/java/org/apache/helix/monitoring/RiemannMonitoringClient.java, > > line 83 > > <https://reviews.apache.org/r/18455/diff/1/?file=503198#file503198line83> > > > > Why use a concurrentmap when we are not using any of the concurrency > > variants on the map? The code seems to be using synchronized methods to > > access the map. > > Zhen Zhang wrote: > we might have a writer and a reader concurrently. not sure if normal > HashMap works in this situation.
If all accesses to a hashmap are in synchronized blocks, it's functionally equivalent to a concurrent hash map. - Kanak ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18455/#review35379 ----------------------------------------------------------- On Feb. 26, 2014, 3:41 p.m., Zhen Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18455/ > ----------------------------------------------------------- > > (Updated Feb. 26, 2014, 3:41 p.m.) > > > Review request for helix, Kanak Biscuitwala and Kishore Gopalakrishna. > > > Repository: helix-git > > > Description > ------- > > [HELIX-319] refactor MonitoringClient to accommodate distributed monitoring > server > > > Diffs > ----- > > helix-core/src/main/java/org/apache/helix/HelixAutoController.java fdab2a6 > helix-core/src/main/java/org/apache/helix/HelixController.java 098fd96 > helix-core/src/main/java/org/apache/helix/HelixManager.java 17c94e5 > > helix-core/src/main/java/org/apache/helix/manager/zk/HelixConnectionAdaptor.java > 65a192a > helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixManager.java > 83eba53 > > helix-core/src/main/java/org/apache/helix/manager/zk/ZkHelixAutoController.java > 3967ed9 > helix-core/src/main/java/org/apache/helix/manager/zk/ZkHelixController.java > 9da59b9 > > helix-core/src/main/java/org/apache/helix/manager/zk/ZkHelixLeaderElection.java > 3c5b3db > helix-core/src/main/java/org/apache/helix/monitoring/MonitoringClient.java > a794eab > helix-core/src/main/java/org/apache/helix/monitoring/MonitoringServer.java > 3168bb2 > helix-core/src/test/java/org/apache/helix/Mocks.java 87d4e68 > helix-core/src/test/java/org/apache/helix/MonitoringTestHelper.java e69de29 > > helix-core/src/test/java/org/apache/helix/controller/stages/DummyClusterManager.java > e07f0b5 > > helix-core/src/test/java/org/apache/helix/participant/MockZKHelixManager.java > 0b8395e > > helix-monitor-client/src/main/java/org/apache/helix/monitoring/RiemannMonitoringClient.java > 20b0825 > helix-monitor-server/pom.xml 041a390 > > helix-monitor-server/src/main/java/org/apache/helix/monitoring/RiemannAgent.java > e69de29 > > helix-monitor-server/src/main/java/org/apache/helix/monitoring/RiemannAgentStateModel.java > e69de29 > > helix-monitor-server/src/main/java/org/apache/helix/monitoring/RiemannAgentStateModelFactory.java > e69de29 > > helix-monitor-server/src/main/java/org/apache/helix/monitoring/RiemannAlertProxy.java > e69de29 > > helix-monitor-server/src/main/java/org/apache/helix/monitoring/RiemannConfigs.java > e69de29 > > helix-monitor-server/src/main/java/org/apache/helix/monitoring/RiemannMonitoringServer.java > 36719aa > > helix-monitor-server/src/test/java/org/apache/helix/monitoring/IntegrationTest.java > e69de29 > > helix-monitor-server/src/test/java/org/apache/helix/monitoring/TestClientServerMonitoring.java > 8b7f839 > > helix-monitor-server/src/test/java/org/apache/helix/monitoring/TestRiemannAgent.java > 6680f00 > > helix-monitor-server/src/test/java/org/apache/helix/monitoring/TestRiemannMonitoringServer.java > e69de29 > > Diff: https://reviews.apache.org/r/18455/diff/ > > > Testing > ------- > > > Thanks, > > Zhen Zhang > >
