----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23515/#review47791 -----------------------------------------------------------
helix-core/src/main/java/org/apache/helix/monitoring/ZKPathDataDumpTask.java <https://reviews.apache.org/r/23515/#comment83992> why did we change it to 96. Can we make this smarter? Always dump once the number of children is X? This will be more useful to debug - Kishore Gopalakrishna On July 15, 2014, 6:33 p.m., Kanak Biscuitwala wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23515/ > ----------------------------------------------------------- > > (Updated July 15, 2014, 6:33 p.m.) > > > Review request for helix, Zhen Zhang and Kishore Gopalakrishna. > > > Bugs: HELIX-472 > > > Repository: helix-git > > > Description > ------- > > commit ca3a5bdaefd1f1c5ae3df4c87b00b29300910dbe > Author: Kanak Biscuitwala <[email protected]> > Date: Tue Jul 15 11:33:43 2014 -0700 > > [HELIX-472] Errors should be cleaned up less frequently > > :100644 100644 a0190d2... 2f5f773... M > helix-core/src/main/java/org/apache/helix/monitoring/ZKPathDataDumpTask.java > > > Diffs > ----- > > > helix-core/src/main/java/org/apache/helix/monitoring/ZKPathDataDumpTask.java > a0190d2 > > Diff: https://reviews.apache.org/r/23515/diff/ > > > Testing > ------- > > > Thanks, > > Kanak Biscuitwala > >
