----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23515/ -----------------------------------------------------------
(Updated July 15, 2014, 2:09 p.m.) Review request for helix, Zhen Zhang and Kishore Gopalakrishna. Changes ------- Refactored dump task to improve readability, allow separate arguments for status update threshold, error threshold, and max leaf node threshold. Added a test to verify max leaf node threshold works. Bugs: HELIX-472 Repository: helix-git Description ------- commit ca3a5bdaefd1f1c5ae3df4c87b00b29300910dbe Author: Kanak Biscuitwala <ka...@apache.org> Date: Tue Jul 15 11:33:43 2014 -0700 [HELIX-472] Errors should be cleaned up less frequently :100644 100644 a0190d2... 2f5f773... M helix-core/src/main/java/org/apache/helix/monitoring/ZKPathDataDumpTask.java Diffs (updated) ----- helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixManager.java d92cc7d helix-core/src/main/java/org/apache/helix/monitoring/ZKPathDataDumpTask.java a0190d2 helix-core/src/test/java/org/apache/helix/integration/TestSchedulerMessage.java 281b306 helix-core/src/test/java/org/apache/helix/monitoring/TestZKPathDataDumpTask.java a3d8ae3 Diff: https://reviews.apache.org/r/23515/diff/ Testing ------- Thanks, Kanak Biscuitwala