[
https://issues.apache.org/jira/browse/HELIX-475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14070717#comment-14070717
]
Hudson commented on HELIX-475:
------------------------------
SUCCESS: Integrated in helix #1267 (See
[https://builds.apache.org/job/helix/1267/])
[HELIX-475] Remove code duplication for Zk tests (zzhang: rev
410815d0fbbdceaffa0664be69266b1c74a3e985)
*
helix-admin-webapp/src/test/java/org/apache/helix/webapp/TestResetResource.java
* helix-core/src/main/java/org/apache/helix/tools/ClusterStateVerifier.java
*
helix-core/src/test/java/org/apache/helix/integration/TestExternalViewUpdates.java
* helix-core/src/test/java/org/apache/helix/integration/TestSwapInstance.java
* helix-core/src/test/java/org/apache/helix/TestHelper.java
*
helix-core/src/test/java/org/apache/helix/integration/TestInstanceAutoJoin.java
*
helix-core/src/test/java/org/apache/helix/integration/TestEnablePartitionDuringDisable.java
*
helix-core/src/test/java/org/apache/helix/integration/TestZkCallbackHandlerLeak.java
*
helix-core/src/test/java/org/apache/helix/integration/TestAutoIsWithEmptyMap.java
*
helix-core/src/test/java/org/apache/helix/integration/TestHelixCustomCodeRunner.java
*
helix-core/src/test/java/org/apache/helix/integration/TestCarryOverBadCurState.java
*
helix-core/src/test/java/org/apache/helix/integration/TestCMWithFailParticipant.java
* helix-core/src/test/java/org/apache/helix/TestConfigAccessor.java
*
helix-core/src/test/java/org/apache/helix/integration/ZkStandAloneCMTestBase.java
*
helix-core/src/test/java/org/apache/helix/integration/TestStateTransitionTimeout.java
* helix-core/src/test/java/org/apache/helix/tools/TestClusterStateVerifier.java
*
helix-core/src/test/java/org/apache/helix/manager/zk/TestZkCacheSyncOpSingleThread.java
*
helix-core/src/test/java/org/apache/helix/api/accessor/TestAccessorRecreate.java
* helix-core/src/test/java/org/apache/helix/tools/TestZkCopy.java
*
helix-core/src/test/java/org/apache/helix/integration/TestSchedulerMessage.java
* helix-core/src/test/java/org/apache/helix/manager/zk/TestZkHelixAdmin.java
*
helix-admin-webapp/src/test/java/org/apache/helix/webapp/TestResetInstance.java
*
helix-core/src/test/java/org/apache/helix/integration/TestFullAutoNodeTagging.java
* helix-core/src/test/java/org/apache/helix/TestListenerCallback.java
* helix-core/src/test/java/org/apache/helix/tools/TestHelixAdminCli.java
*
helix-core/src/test/java/org/apache/helix/monitoring/TestClusterStatusMonitorLifecycle.java
*
helix-core/src/test/java/org/apache/helix/integration/TestInvalidAutoIdealState.java
* helix-core/src/test/java/org/apache/helix/integration/TestMessageThrottle.java
*
helix-core/src/test/java/org/apache/helix/integration/task/TestTaskRebalancerStopResume.java
* helix-admin-webapp/src/test/java/org/apache/helix/webapp/AdminTestBase.java
*
helix-core/src/test/java/org/apache/helix/integration/TestStandAloneCMMain.java
*
helix-core/src/test/java/org/apache/helix/participant/TestDistControllerStateModelFactory.java
* helix-core/src/test/java/org/apache/helix/TestHierarchicalDataStore.java
*
helix-core/src/test/java/org/apache/helix/integration/manager/TestConsecutiveZkSessionExpiry.java
*
helix-core/src/test/java/org/apache/helix/manager/zk/TestZkManagerFlappingDetection.java
*
helix-core/src/test/java/org/apache/helix/integration/manager/TestDistributedControllerManager.java
* helix-core/src/test/java/org/apache/helix/integration/TestSchemataSM.java
*
helix-admin-webapp/src/test/java/org/apache/helix/webapp/TestResetPartitionState.java
* helix-core/src/test/java/org/apache/helix/integration/TestDisableResource.java
* helix-core/src/test/java/org/apache/helix/integration/TestZkSessionExpiry.java
* helix-core/src/test/java/org/apache/helix/testutil/ZkTestBase.java
*
helix-core/src/test/java/org/apache/helix/manager/zk/TestZkHelixController.java
*
helix-core/src/test/java/org/apache/helix/integration/TestResetPartitionState.java
* helix-core/src/test/java/org/apache/helix/TestHelixConfigAccessor.java
* helix-core/src/test/java/org/apache/helix/lock/zk/TestZKHelixLock.java
*
helix-core/src/test/java/org/apache/helix/messaging/handling/TestConfigThreadpoolSize.java
* helix-core/src/test/java/org/apache/helix/integration/TestRenamePartition.java
*
helix-core/src/test/java/org/apache/helix/integration/TestPartitionLevelTransitionConstraint.java
*
helix-core/src/test/java/org/apache/helix/integration/TestNonOfflineInitState.java
*
helix-core/src/test/java/org/apache/helix/manager/zk/TestZkHelixAutoController.java
* helix-core/src/test/java/org/apache/helix/TestZKCallback.java
* helix-agent/src/test/java/org/apache/helix/agent/TestHelixAgent.java
* helix-core/src/test/java/org/apache/helix/manager/zk/TestZKUtil.java
*
helix-core/src/test/java/org/apache/helix/integration/TestDistributedCMMain.java
*
helix-core/src/test/java/org/apache/helix/controller/stages/TestMessageThrottleStage.java
* helix-core/src/test/java/org/apache/helix/integration/TestPauseSignal.java
*
helix-core/src/test/java/org/apache/helix/integration/TestDisableCustomCodeRunner.java
* helix-core/src/test/java/org/apache/helix/integration/TestStatusUpdate.java
*
helix-core/src/test/java/org/apache/helix/integration/ZkIntegrationTestBase.java
* helix-core/src/test/java/org/apache/helix/integration/TestDropResource.java
*
helix-core/src/test/java/org/apache/helix/participant/TestDistControllerStateModel.java
*
helix-core/src/test/java/org/apache/helix/integration/manager/TestZkCallbackHandlerLeak.java
*
helix-core/src/test/java/org/apache/helix/integration/TestHelixInstanceTag.java
*
helix-core/src/test/java/org/apache/helix/controller/stages/TestRebalancePipeline.java
*
helix-core/src/test/java/org/apache/helix/messaging/handling/TestResourceThreadpoolSize.java
* helix-core/src/test/java/org/apache/helix/TestZkBasis.java
* helix-core/src/test/java/org/apache/helix/integration/TestHelixConnection.java
*
helix-core/src/test/java/org/apache/helix/integration/TestStartMultipleControllersWithSameName.java
* helix-core/src/test/java/org/apache/helix/integration/TestAddClusterV2.java
*
helix-core/src/test/java/org/apache/helix/api/accessor/TestAtomicAccessors.java
*
helix-core/src/test/java/org/apache/helix/manager/zk/TestLiveInstanceBounce.java
*
helix-core/src/test/java/org/apache/helix/manager/zk/TestZKLiveInstanceData.java
*
helix-core/src/test/java/org/apache/helix/integration/TestAddNodeAfterControllerStart.java
*
helix-core/src/test/java/org/apache/helix/integration/TestReelectedPipelineCorrectness.java
* helix-core/src/test/java/org/apache/helix/integration/TestClusterStartsup.java
*
helix-core/src/test/java/org/apache/helix/integration/TestBatchMessageWrapper.java
*
helix-core/src/test/java/org/apache/helix/integration/TestSessionExpiryInTransition.java
*
helix-core/src/test/java/org/apache/helix/integration/manager/TestStateModelLeak.java
*
helix-core/src/test/java/org/apache/helix/integration/TestParticipantNameCollision.java
*
helix-core/src/test/java/org/apache/helix/manager/zk/TestZkHelixParticipant.java
*
helix-core/src/test/java/org/apache/helix/integration/TestLocalContainerProvider.java
*
helix-core/src/test/java/org/apache/helix/integration/TestRedefineStateModelDef.java
*
helix-core/src/test/java/org/apache/helix/integration/TestUserDefRebalancerCompatibility.java
* helix-core/src/test/java/org/apache/helix/ZkUnitTestBase.java
*
helix-core/src/test/java/org/apache/helix/store/zk/TestZkManagerWithAutoFallbackStore.java
*
helix-admin-webapp/src/test/java/org/apache/helix/webapp/TestDisableResource.java
*
helix-core/src/test/java/org/apache/helix/integration/TestDisablePartition.java
*
helix-core/src/test/java/org/apache/helix/integration/task/TestIndependentTaskRebalancer.java
*
helix-core/src/test/java/org/apache/helix/manager/zk/TestWtCacheAsyncOpMultiThread.java
*
helix-core/src/test/java/org/apache/helix/manager/zk/TestZkBaseDataAccessor.java
* helix-core/src/test/java/org/apache/helix/integration/TestZkReconnect.java
* helix-core/src/test/java/org/apache/helix/model/TestConstraint.java
* helix-core/src/test/java/org/apache/helix/manager/zk/TestZkClusterManager.java
*
helix-admin-webapp/src/test/java/org/apache/helix/webapp/TestHelixAdminScenariosRest.java
*
helix-core/src/test/java/org/apache/helix/integration/TestPreferenceListAsQueue.java
* helix-core/src/test/java/org/apache/helix/integration/TestDisable.java
*
helix-core/src/test/java/org/apache/helix/integration/TestDistributedClusterController.java
* helix-core/src/test/java/org/apache/helix/tools/TestClusterSetup.java
* helix-core/src/test/java/org/apache/helix/integration/TestBasicSpectator.java
*
helix-core/src/test/java/org/apache/helix/store/zk/TestAutoFallbackPropertyStore.java
*
helix-core/src/test/java/org/apache/helix/integration/manager/TestParticipantManager.java
*
helix-core/src/test/java/org/apache/helix/integration/TestEntropyFreeNodeBounce.java
*
helix-core/src/test/java/org/apache/helix/integration/TestSharedConnection.java
* helix-core/src/test/java/org/apache/helix/integration/TestDriver.java
*
helix-core/src/test/java/org/apache/helix/monitoring/TestZKPathDataDumpTask.java
* helix-core/src/test/java/org/apache/helix/integration/TestResetResource.java
*
helix-core/src/test/java/org/apache/helix/store/zk/TestZkHelixPropertyStore.java
*
helix-core/src/test/java/org/apache/helix/monitoring/mbeans/TestDropResourceMetricsReset.java
* helix-core/src/test/java/org/apache/helix/integration/TestExpandCluster.java
*
helix-core/src/test/java/org/apache/helix/manager/zk/TestZkCacheAsyncOpSingleThread.java
* helix-core/src/test/java/org/apache/helix/api/TestNewStages.java
*
helix-core/src/test/java/org/apache/helix/integration/TestAddStateModelFactoryAfterConnect.java
* helix-core/src/test/java/org/apache/helix/testutil/ZkTestUtil.java
*
helix-core/src/test/java/org/apache/helix/integration/TestMessageThrottle2.java
*
helix-core/src/test/java/org/apache/helix/manager/zk/TestWtCacheSyncOpSingleThread.java
*
helix-core/src/test/java/org/apache/helix/integration/TestBucketizedResource.java
*
helix-core/src/test/java/org/apache/helix/integration/TestCleanupExternalView.java
*
helix-core/src/test/java/org/apache/helix/integration/TestAutoRebalancePartitionLimit.java
*
helix-core/src/test/java/org/apache/helix/manager/zk/TestWtCacheAsyncOpSingleThread.java
* helix-core/src/test/java/org/apache/helix/integration/TestDisableNode.java
* helix-core/src/test/java/org/apache/helix/integration/TestBatchMessage.java
*
helix-core/src/test/java/org/apache/helix/integration/TestCustomizedIdealStateRebalancer.java
* helix-core/src/test/java/org/apache/helix/integration/TestNullReplica.java
* helix-core/src/test/java/org/apache/helix/integration/TestAutoRebalance.java
*
helix-core/src/test/java/org/apache/helix/integration/TestInvalidResourceRebalance.java
*
helix-core/src/test/java/org/apache/helix/integration/TestRestartParticipant.java
*
helix-core/src/test/java/org/apache/helix/integration/manager/TestControllerManager.java
*
helix-core/src/test/java/org/apache/helix/integration/TestStandAloneCMSessionExpiry.java
* helix-core/src/test/java/org/apache/helix/manager/zk/TestHandleNewSession.java
* helix-core/src/test/java/org/apache/helix/TestZkClientWrapper.java
* helix-core/src/test/java/org/apache/helix/testutil/TestUtil.java
*
helix-core/src/test/java/org/apache/helix/monitoring/mbeans/TestResetClusterMetrics.java
*
helix-core/src/test/java/org/apache/helix/integration/task/TestTaskRebalancer.java
* helix-core/src/test/java/org/apache/helix/integration/TestDrop.java
* helix-core/src/test/java/org/apache/helix/TestZkConnectionCount.java
*
helix-core/src/test/java/org/apache/helix/manager/zk/TestZNRecordSizeLimit.java
* helix-core/src/test/java/org/apache/helix/integration/TestResetInstance.java
* helix-core/src/test/java/org/apache/helix/manager/zk/TestZkFlapping.java
*
helix-core/src/test/java/org/apache/helix/integration/TestCustomIdealState.java
*
helix-admin-webapp/src/test/java/org/apache/helix/webapp/TestClusterManagementWebapp.java
*
helix-core/src/test/java/org/apache/helix/integration/TestParticipantErrorMessage.java
* helix-core/src/test/java/org/apache/helix/testutil/HelixTestUtil.java
*
helix-core/src/test/java/org/apache/helix/integration/TestHelixUsingDifferentParams.java
*
helix-core/src/test/java/org/apache/helix/participant/TestDistControllerElection.java
* helix-core/src/test/java/org/apache/helix/TestZnodeModify.java
* helix-core/src/test/java/org/apache/helix/integration/TestErrorPartition.java
> Remove code duplication for Zk tests
> ------------------------------------
>
> Key: HELIX-475
> URL: https://issues.apache.org/jira/browse/HELIX-475
> Project: Apache Helix
> Issue Type: Improvement
> Reporter: Zhen Zhang
> Assignee: Zhen Zhang
>
> Currently we have ZkUniteTestBae, ZkIntegrationTestBase, and AdminTestBase
> that start and stop zk server for all zk-based tests. The code are duplicated
> and zk addresses are hard-coded (e.g. "localhost:2183", "localhost:2185").
> Need to remove duplicated code and change to use dynamic port allocation for
> local zk server.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
