----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23821/ -----------------------------------------------------------
Review request for helix, Zhen Zhang and Kishore Gopalakrishna. Bugs: HELIX-389 Repository: helix-git Description ------- commit 189dafd98598a693d811cff58cdf5e5f6cd0a3bc Author: Kanak Biscuitwala <[email protected]> Date: Tue Jul 22 12:05:05 2014 -0700 [HELIX-389] Unify accessor classes into a single class :100644 100644 c56b01a... ff5f458... M helix-core/src/main/java/org/apache/helix/HelixConnection.java :100644 100644 1153032... 239748c... M helix-core/src/main/java/org/apache/helix/api/Resource.java :100644 100644 216b3ad... 83fde95... M helix-core/src/main/java/org/apache/helix/api/accessor/AtomicClusterAccessor.java :100644 000000 6b9b10e... 0000000... D helix-core/src/main/java/org/apache/helix/api/accessor/AtomicParticipantAccessor.java :100644 000000 65fda39... 0000000... D helix-core/src/main/java/org/apache/helix/api/accessor/AtomicResourceAccessor.java :100644 100644 92fb636... 21d40b1... M helix-core/src/main/java/org/apache/helix/api/accessor/ClusterAccessor.java :100644 000000 609e458... 0000000... D helix-core/src/main/java/org/apache/helix/api/accessor/ControllerAccessor.java :100644 000000 cb52e91... 0000000... D helix-core/src/main/java/org/apache/helix/api/accessor/ParticipantAccessor.java :100644 000000 7dde6ee... 0000000... D helix-core/src/main/java/org/apache/helix/api/accessor/ResourceAccessor.java :100644 100644 6185383... 26df5d7... M helix-core/src/main/java/org/apache/helix/api/config/ResourceConfig.java :100644 100644 4d5c373... e884ff8... M helix-core/src/main/java/org/apache/helix/controller/rebalancer/CustomRebalancer.java :100644 100644 e00e57c... 6f5575a... M helix-core/src/main/java/org/apache/helix/controller/rebalancer/FallbackRebalancer.java :100644 100644 4bf030b... c1d32da... M helix-core/src/main/java/org/apache/helix/controller/rebalancer/FullAutoRebalancer.java :100644 100644 1fbb02f... 9de571d... M helix-core/src/main/java/org/apache/helix/controller/rebalancer/HelixRebalancer.java :100644 100644 07f6337... fbf06d2... M helix-core/src/main/java/org/apache/helix/controller/rebalancer/SemiAutoRebalancer.java :100644 100644 dd661d9... 934a9c2... M helix-core/src/main/java/org/apache/helix/controller/rebalancer/config/PartitionedRebalancerConfig.java :100644 100644 364c370... 6f34953... M helix-core/src/main/java/org/apache/helix/controller/stages/BestPossibleStateCalcStage.java :100644 100644 64bf792... 4cc1b9f... M helix-core/src/main/java/org/apache/helix/controller/stages/CurrentStateComputationStage.java :100644 100644 fc247a6... 9f2721f... M helix-core/src/main/java/org/apache/helix/controller/stages/ExternalViewComputeStage.java :100644 100644 a49feae... 893e116... M helix-core/src/main/java/org/apache/helix/controller/stages/MessageGenerationStage.java :100644 100644 9f894e7... 1fc7142... M helix-core/src/main/java/org/apache/helix/controller/stages/ResourceComputationStage.java :100644 100644 ea2536d... bec6f5c... M helix-core/src/main/java/org/apache/helix/manager/zk/ZkHelixConnection.java :100644 100644 475b3cf... f9529b7... M helix-core/src/main/java/org/apache/helix/manager/zk/ZkHelixController.java :100644 100644 d42b7b7... 674140e... M helix-core/src/main/java/org/apache/helix/manager/zk/ZkHelixParticipant.java :100644 100644 dc42a52... 88ec610... M helix-core/src/main/java/org/apache/helix/model/IdealState.java :100644 100644 0e11d21... 29990ed... M helix-core/src/main/java/org/apache/helix/task/TaskRebalancer.java :100644 100644 0a8a41d... 6599b33... M helix-core/src/main/java/org/apache/helix/tools/ClusterSetup.java :100644 000000 c8281ba... 0000000... D helix-core/src/main/java/org/apache/helix/tools/NewClusterSetup.java :100644 100644 2b94f7b... a35a47b... M helix-core/src/test/java/org/apache/helix/api/TestNewStages.java :100644 100644 3c8fb2c... a8d1589... M helix-core/src/test/java/org/apache/helix/api/TestUpdateConfig.java :100644 100644 22904fb... c068132... M helix-core/src/test/java/org/apache/helix/api/accessor/TestAccessorRecreate.java :100644 100644 096a883... 29228e4... M helix-core/src/test/java/org/apache/helix/controller/stages/TestMessageThrottleStage.java :100644 100644 a5cc614... 922dde6... M helix-core/src/test/java/org/apache/helix/controller/stages/TestRebalancePipeline.java :100644 100644 90ea393... 04a25e9... M helix-core/src/test/java/org/apache/helix/controller/stages/TestResourceComputationStage.java :100644 100644 73f7e82... b03a48b... M helix-core/src/test/java/org/apache/helix/integration/TestCustomizedIdealStateRebalancer.java :100644 100644 6aac417... 1315574... M helix-core/src/test/java/org/apache/helix/integration/TestHelixConnection.java :100644 100644 b3c4c66... c5b055b... M helix-core/src/test/java/org/apache/helix/integration/TestLocalContainerProvider.java :100644 100644 8c9ab01... fe041d0... M helix-core/src/test/java/org/apache/helix/monitoring/mbeans/TestClusterStatusMonitor.java :100644 100644 515fdab... 163ac5e... M helix-examples/src/main/java/org/apache/helix/examples/LogicalModelExample.java :100644 100644 d937c5c... 630ab4a... M helix-provisioning/src/main/java/org/apache/helix/provisioning/participant/StatelessParticipantService.java :100644 100644 f0e3d37... fcc137b... M helix-provisioning/src/main/java/org/apache/helix/provisioning/tools/ContainerAdmin.java :100644 100644 f6713d1... acb544a... M helix-provisioning/src/main/java/org/apache/helix/provisioning/tools/UpdateProvisionerConfig.java :100644 100644 31ef05c... 5a683b0... M helix-provisioning/src/main/java/org/apache/helix/provisioning/yarn/AppMasterLauncher.java :100644 100644 c436443... 5fba08f... M helix-provisioning/src/main/java/org/apache/helix/provisioning/yarn/AppStatusReportGenerator.java :100644 100644 3b92f33... ddbf27a... M recipes/jobrunner-yarn/src/main/java/org/apache/helix/provisioning/yarn/example/JobRunnerMain.java :100644 100644 7409f1b... b3e90e1... M recipes/rsync-replicated-file-system/src/main/java/org/apache/helix/filestore/ChangeLogReader.java :100644 100644 3693c2b... a232842... M recipes/user-defined-rebalancer/src/main/java/org/apache/helix/userdefinedrebalancer/LockManagerRebalancer.java Diffs ----- helix-core/src/main/java/org/apache/helix/HelixConnection.java c56b01a helix-core/src/main/java/org/apache/helix/api/Resource.java 1153032 helix-core/src/main/java/org/apache/helix/api/accessor/AtomicClusterAccessor.java 216b3ad helix-core/src/main/java/org/apache/helix/api/accessor/AtomicParticipantAccessor.java 6b9b10e helix-core/src/main/java/org/apache/helix/api/accessor/AtomicResourceAccessor.java 65fda39 helix-core/src/main/java/org/apache/helix/api/accessor/ClusterAccessor.java 92fb636 helix-core/src/main/java/org/apache/helix/api/accessor/ControllerAccessor.java 609e458 helix-core/src/main/java/org/apache/helix/api/accessor/ParticipantAccessor.java cb52e91 helix-core/src/main/java/org/apache/helix/api/accessor/ResourceAccessor.java 7dde6ee helix-core/src/main/java/org/apache/helix/api/config/ResourceConfig.java 6185383 helix-core/src/main/java/org/apache/helix/controller/rebalancer/CustomRebalancer.java 4d5c373 helix-core/src/main/java/org/apache/helix/controller/rebalancer/FallbackRebalancer.java e00e57c helix-core/src/main/java/org/apache/helix/controller/rebalancer/FullAutoRebalancer.java 4bf030b helix-core/src/main/java/org/apache/helix/controller/rebalancer/HelixRebalancer.java 1fbb02f helix-core/src/main/java/org/apache/helix/controller/rebalancer/SemiAutoRebalancer.java 07f6337 helix-core/src/main/java/org/apache/helix/controller/rebalancer/config/PartitionedRebalancerConfig.java dd661d9 helix-core/src/main/java/org/apache/helix/controller/stages/BestPossibleStateCalcStage.java 364c370 helix-core/src/main/java/org/apache/helix/controller/stages/CurrentStateComputationStage.java 64bf792 helix-core/src/main/java/org/apache/helix/controller/stages/ExternalViewComputeStage.java fc247a6 helix-core/src/main/java/org/apache/helix/controller/stages/MessageGenerationStage.java a49feae helix-core/src/main/java/org/apache/helix/controller/stages/ResourceComputationStage.java 9f894e7 helix-core/src/main/java/org/apache/helix/manager/zk/ZkHelixConnection.java ea2536d helix-core/src/main/java/org/apache/helix/manager/zk/ZkHelixController.java 475b3cf helix-core/src/main/java/org/apache/helix/manager/zk/ZkHelixParticipant.java d42b7b7 helix-core/src/main/java/org/apache/helix/model/IdealState.java dc42a52 helix-core/src/main/java/org/apache/helix/task/TaskRebalancer.java 0e11d21 helix-core/src/main/java/org/apache/helix/tools/ClusterSetup.java 0a8a41d helix-core/src/main/java/org/apache/helix/tools/NewClusterSetup.java c8281ba helix-core/src/test/java/org/apache/helix/api/TestNewStages.java 2b94f7b helix-core/src/test/java/org/apache/helix/api/TestUpdateConfig.java 3c8fb2c helix-core/src/test/java/org/apache/helix/api/accessor/TestAccessorRecreate.java 22904fb helix-core/src/test/java/org/apache/helix/controller/stages/TestMessageThrottleStage.java 096a883 helix-core/src/test/java/org/apache/helix/controller/stages/TestRebalancePipeline.java a5cc614 helix-core/src/test/java/org/apache/helix/controller/stages/TestResourceComputationStage.java 90ea393 helix-core/src/test/java/org/apache/helix/integration/TestCustomizedIdealStateRebalancer.java 73f7e82 helix-core/src/test/java/org/apache/helix/integration/TestHelixConnection.java 6aac417 helix-core/src/test/java/org/apache/helix/integration/TestLocalContainerProvider.java b3c4c66 helix-core/src/test/java/org/apache/helix/monitoring/mbeans/TestClusterStatusMonitor.java 8c9ab01 helix-examples/src/main/java/org/apache/helix/examples/LogicalModelExample.java 515fdab helix-provisioning/src/main/java/org/apache/helix/provisioning/participant/StatelessParticipantService.java d937c5c helix-provisioning/src/main/java/org/apache/helix/provisioning/tools/ContainerAdmin.java f0e3d37 helix-provisioning/src/main/java/org/apache/helix/provisioning/tools/UpdateProvisionerConfig.java f6713d1 helix-provisioning/src/main/java/org/apache/helix/provisioning/yarn/AppMasterLauncher.java 31ef05c helix-provisioning/src/main/java/org/apache/helix/provisioning/yarn/AppStatusReportGenerator.java c436443 recipes/jobrunner-yarn/src/main/java/org/apache/helix/provisioning/yarn/example/JobRunnerMain.java 3b92f33 recipes/rsync-replicated-file-system/src/main/java/org/apache/helix/filestore/ChangeLogReader.java 7409f1b recipes/user-defined-rebalancer/src/main/java/org/apache/helix/userdefinedrebalancer/LockManagerRebalancer.java 3693c2b Diff: https://reviews.apache.org/r/23821/diff/ Testing ------- Existing tests pass. Thanks, Kanak Biscuitwala
