> On Nov. 14, 2014, 1:34 a.m., Kishore Gopalakrishna wrote: > > helix-core/src/main/java/org/apache/helix/controller/strategy/AutoRebalanceStrategy.java, > > line 443 > > <https://reviews.apache.org/r/28023/diff/1/?file=763197#file763197line443> > > > > This is a sutle change, can you add please add more comments here and a > > test case where the previous code fails and new code passed
detail comments are here: https://issues.apache.org/jira/browse/HELIX-547 It also contains inputs that can constantly reproduce the problem. I will add a test case for it. - Zhen ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28023/#review61367 ----------------------------------------------------------- On Nov. 14, 2014, 1:20 a.m., Zhen Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28023/ > ----------------------------------------------------------- > > (Updated Nov. 14, 2014, 1:20 a.m.) > > > Review request for helix and Shi Lu. > > > Bugs: HELIX-547 > > > Repository: helix-git > > > Description > ------- > > [HELIX-547] AutoRebalancer may not converge in some rare situation > > > Diffs > ----- > > > helix-core/src/main/java/org/apache/helix/controller/strategy/AutoRebalanceStrategy.java > 768286b > > Diff: https://reviews.apache.org/r/28023/diff/ > > > Testing > ------- > > mvn test > > > Thanks, > > Zhen Zhang > >
