----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28023/#review62126 -----------------------------------------------------------
Code looks good, but it needs a unit test. - Kanak Biscuitwala On Nov. 13, 2014, 5:20 p.m., Zhen Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28023/ > ----------------------------------------------------------- > > (Updated Nov. 13, 2014, 5:20 p.m.) > > > Review request for helix and Shi Lu. > > > Bugs: HELIX-547 > > > Repository: helix-git > > > Description > ------- > > [HELIX-547] AutoRebalancer may not converge in some rare situation > > > Diffs > ----- > > > helix-core/src/main/java/org/apache/helix/controller/strategy/AutoRebalanceStrategy.java > 768286b > > Diff: https://reviews.apache.org/r/28023/diff/ > > > Testing > ------- > > mvn test > > > Thanks, > > Zhen Zhang > >
