Github user kanakb commented on a diff in the pull request:
https://github.com/apache/helix/pull/15#discussion_r24715263
--- Diff: contributors/py-helix-admin/helix/cluster.py ---
@@ -48,15 +52,13 @@ def __str__(self):
self.cluster)
def __repr__(self):
- return "{0}({1}, {2})".format(self.__class__.__name__,
self.cluster,
- self.host)
+ return "{0}({1}, {2})".format(self.__class__.__name__,
self.cluster)
def load_resources(self):
"""queries helix for resource groups and loades them into model"""
try:
- for cur_resource in functions.get_resource_groups(self.host,
-
self.cluster):
- data = functions.get_resource_group(self.host,
self.cluster,
+ for cur_resource in
self.functions.get_resource_groups(self.cluster):
+ data = self.functions.get_resource_group(self.cluster,
cur_resource)
--- End diff --
nit: argument after line break doesn't seem to align with arguments on the
first line
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
