Github user camillser commented on a diff in the pull request:

    https://github.com/apache/helix/pull/15#discussion_r24725576
  
    --- Diff: contributors/py-helix-admin/helix/statemodeldefs.py ---
    @@ -0,0 +1,39 @@
    +from ordereddict import OrderedDict
    +
    +# These essentially come from the java classes defined here. It is cheesey 
and should probably come from a configuration file.
    +# 
https://github.com/linkedin/helix/blob/master/helix-core/src/main/java/com/linkedin/helix/tools/StateModelConfigGenerator.java
    +
    --- End diff --
    
    I use ordereddict because I think there are places where ordering matters 
with regards to the data in zookeeper. Using ordereddict ensures compatibility 
as python dictionaries (and the json parser) do not guarantee ordering. Let me 
know if the ordering requirement can be dropped and I can easily rewrite this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to