----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31397/#review73966 -----------------------------------------------------------
helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixManager.java <https://reviews.apache.org/r/31397/#comment120370> can we avoid bringing code from tools into core? tools package has lot of unwanted code and we should move it out into helix-tools module. when we do that helix-tools will depend on helix-core helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixManager.java <https://reviews.apache.org/r/31397/#comment120374> we should call it addDefaultStateModelDefinitions() helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixManager.java <https://reviews.apache.org/r/31397/#comment120371> why is this removed as part of this rb? helix-core/src/main/java/org/apache/helix/tools/ClusterSetup.java <https://reviews.apache.org/r/31397/#comment120372> we need to chose a better name, we DefaultStateModelDefinition seems like a one that we would use if no state model is specified. helix-core/src/main/java/org/apache/helix/tools/StateModelConfigGenerator.java <https://reviews.apache.org/r/31397/#comment120373> I like that we have one place to view all the statemodels, we should get rid of state model config generator class and have one class for each statemodeldefinition - Kishore Gopalakrishna On Feb. 25, 2015, 1:39 a.m., Zhen Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31397/ > ----------------------------------------------------------- > > (Updated Feb. 25, 2015, 1:39 a.m.) > > > Review request for helix, Kishore Gopalakrishna and Shi Lu. > > > Bugs: 570 > > > Repository: helix-git > > > Description > ------- > > When controller starts, we can add missing default state model definitions to > the cluster. This is useful for example, a legacy cluster is created without > some new default state model definitions. Instead of building a tool to > populate the new default state model definitions to existing clusters, > controller can check this and add it if necessary. > > > Diffs > ----- > > > helix-core/src/main/java/org/apache/helix/controller/HelixControllerMain.java > b6c16b5 > helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixManager.java > 3328279 > helix-core/src/main/java/org/apache/helix/tools/ClusterSetup.java 40bc398 > > helix-core/src/main/java/org/apache/helix/tools/StateModelConfigGenerator.java > b8b3aeb > > helix-core/src/test/java/org/apache/helix/manager/zk/TestAddDefaultStateModelDef.java > e69de29 > > Diff: https://reviews.apache.org/r/31397/diff/ > > > Testing > ------- > > mvn test > > > Thanks, > > Zhen Zhang > >
