----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31397/ -----------------------------------------------------------
(Updated Feb. 26, 2015, 2:23 a.m.) Review request for helix, Kishore Gopalakrishna and Shi Lu. Changes ------- apply comments Bugs: 570 Repository: helix-git Description ------- When controller starts, we can add missing default state model definitions to the cluster. This is useful for example, a legacy cluster is created without some new default state model definitions. Instead of building a tool to populate the new default state model definitions to existing clusters, controller can check this and add it if necessary. Diffs (updated) ----- helix-core/src/main/java/org/apache/helix/controller/HelixControllerMain.java b6c16b5 helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixManager.java 3328279 helix-core/src/main/java/org/apache/helix/model/BuildInSMD.java e69de29 helix-core/src/main/java/org/apache/helix/model/LeaderStandbySMD.java e69de29 helix-core/src/main/java/org/apache/helix/model/MasterSlaveSMD.java e69de29 helix-core/src/main/java/org/apache/helix/model/OnlineOfflineSMD.java e69de29 helix-core/src/main/java/org/apache/helix/model/ScheduledTaskSMD.java e69de29 helix-core/src/main/java/org/apache/helix/model/StorageSchemataSMD.java e69de29 helix-core/src/main/java/org/apache/helix/model/TaskSMD.java e69de29 helix-core/src/main/java/org/apache/helix/tools/ClusterSetup.java 40bc398 helix-core/src/main/java/org/apache/helix/tools/StateModelConfigGenerator.java b8b3aeb helix-core/src/test/java/org/apache/helix/manager/zk/TestAddDefaultStateModelDef.java e69de29 Diff: https://reviews.apache.org/r/31397/diff/ Testing ------- mvn test Thanks, Zhen Zhang
