[ https://issues.apache.org/jira/browse/HELIX-592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14520496#comment-14520496 ]
ASF GitHub Bot commented on HELIX-592: -------------------------------------- GitHub user jicongrui opened a pull request: https://github.com/apache/helix/pull/26 [HELIX-592] addCluster should respect overwriteExisitng when adding stat... ...eModelDefinations There are some tests expecting exceptions when creating an existing cluster and I change the result. So the question is that the business logic of creating a exisiting cluster. If we allow that and overwrite is false, should we throw exceptions or do nothing? You can merge this pull request into a Git repository by running: $ git pull https://github.com/jicongrui/helix helix-0.6.x Alternatively you can review and apply these changes as the patch at: https://github.com/apache/helix/pull/26.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #26 ---- commit 69cd1f27065710f6de157b82742673ab8baf5d11 Author: Congrui Ji <c...@linkedin.com> Date: 2015-04-29T23:13:11Z [HELIX-592] addCluster should respect overwriteExisitng when adding stateModelDefinations There are some tests expecting exceptions when creating an existing cluster and I change the result. So the question is that the business logic of creating a exisiting cluster. If we allow that and overwrite is false, should we throw exceptions or do nothing? ---- > addCluster should respect overwriteExisitng when adding stateModelDefinations > ----------------------------------------------------------------------------- > > Key: HELIX-592 > URL: https://issues.apache.org/jira/browse/HELIX-592 > Project: Apache Helix > Issue Type: Bug > Reporter: Congrui Ji > > Currently addCluster in clusterSetup.java ignores the overwriteExisitng > parameter while adding stateModelDefinations. This causes exception > -StateModelDef already exist. please help fix this -- This message was sent by Atlassian JIRA (v6.3.4#6332)