Github user kishoreg commented on a diff in the pull request:
https://github.com/apache/helix/pull/32#discussion_r34959249
--- Diff:
helix-core/src/main/java/org/apache/helix/controller/stages/ExternalViewComputeStage.java
---
@@ -78,6 +78,18 @@ public void process(ClusterEvent event) throws Exception
{
dataAccessor.getChildValuesMap(keyBuilder.externalViews());
for (String resourceName : resourceMap.keySet()) {
+ IdealState idealState = cache._idealStateMap.get(resourceName);
+
+ // skip generate external view if the ExternalViewDisabled flag is
set in IdealState
+ if (idealState != null && idealState.isExternalViewDisabled()) {
--- End diff --
What happens when the resource gets deleted? The isExternalViewDisabled in
Idealstate is not available and we might write external views for all the
resources.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
