Github user lei-xia commented on the pull request:
https://github.com/apache/helix/pull/32#issuecomment-124138753
For clusterStateVerifier, we will ignore the resources with
DisableExternalView set true. Since for now, only job resource will use that
option, and usually there are other ways to report error for jobs, instead of
comparing IS and EV. (for example, from job context in property store).
For the clusterStatus monitoring bean, that is a good point. I have
updated the code in ExternViewComputingStage. Now, instead of totally skipping
this stage for such resource as my previous code, we still compute externalView
for verifying and reporting cluster/resource status purpose, but we will not
actually create or write the externalView to ZooKeeper. This fix the
clusterStatus (resource status) mbean problem (verified locally).
Thanks for the review!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
