[ 
https://issues.apache.org/jira/browse/HELIX-610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14737203#comment-14737203
 ] 

ASF GitHub Bot commented on HELIX-610:
--------------------------------------

Github user liyinan926 commented on the pull request:

    https://github.com/apache/helix/pull/35#issuecomment-138976620
  
    @kishoreg I do have a reference to a `TaskStateModelFactory` instance, but 
I don't have reference to any `TaskStateModel` instances created by it though 
so I cannot call shutdown directly. It also seems the only place 
`TaskStateModelFactory.createStateTransitionHandler` is called is in 
`StateTransitionHandlerFactory.createAndAddSTransitionHandler`, which doesn't 
know about the `shutdown` method specific to `TaskStateModel`. I think what I 
can do is to add a `shutdown` method to `TaskStateModelFactory` and store 
references to all created `TaskStateModel` instances in the 
`TaskStateModelFactory` and shutdown all of them in 
`TaskStateModelFactory.shutdown`.


> TaskStateModel does not get properly shutdown when the JVM exists
> -----------------------------------------------------------------
>
>                 Key: HELIX-610
>                 URL: https://issues.apache.org/jira/browse/HELIX-610
>             Project: Apache Helix
>          Issue Type: Bug
>            Reporter: Yinan Li
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to