[
https://issues.apache.org/jira/browse/HELIX-610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14737235#comment-14737235
]
ASF GitHub Bot commented on HELIX-610:
--------------------------------------
Github user kishoreg commented on the pull request:
https://github.com/apache/helix/pull/35#issuecomment-138981788
@liyinan926
https://github.com/apache/helix/blob/master/helix-core/src/main/java/org/apache/helix/api/StateTransitionHandlerFactory.java
If you look at the methods here, you should be able to get references to all
TransitionHandlers.
getResourceSet and then for each resource get PartitionSet and for each
partition get the transition handler. You can then call shutdown on the
transition handler.
Note that I agree with you that we need a way to gracefully shutdown all
transition handlers but it would be great to handle this in one place and make
it common to all transition handlers rather than making it specific to
taskstatemodel. Do you think you can extend this change to all transition
handler? Note that with this we only need to have a shutdownhook in
helixstatemachineengine and we should be able to get references to all
statemodels.
This will also slow down the shutdown process depending on whats done in
shutdown method. May be we can use a marker interface to indicate that
shutdown method should be invoked for these handlers
> TaskStateModel does not get properly shutdown when the JVM exists
> -----------------------------------------------------------------
>
> Key: HELIX-610
> URL: https://issues.apache.org/jira/browse/HELIX-610
> Project: Apache Helix
> Issue Type: Bug
> Reporter: Yinan Li
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
