Github user kongweihan commented on a diff in the pull request:
https://github.com/apache/helix/pull/89#discussion_r115830770
--- Diff:
helix-core/src/main/java/org/apache/helix/controller/stages/BestPossibleStateCalcStage.java
---
@@ -90,60 +96,86 @@ private BestPossibleStateOutput compute(ClusterEvent
event, Map<String, Resource
BestPossibleStateOutput output = new BestPossibleStateOutput();
- for (String resourceName : resourceMap.keySet()) {
- logger.debug("Processing resource:" + resourceName);
+ // Reset current INIT/RUNNING tasks on participants for throttling
+ JobRebalancer.resetActiveTaskCount(cache.getLiveInstances().keySet(),
currentStateOutput);
- Resource resource = resourceMap.get(resourceName);
- // Ideal state may be gone. In that case we need to get the state
model name
- // from the current state
- IdealState idealState = cache.getIdealState(resourceName);
+ PriorityQueue<JobResourcePriority> jobResourceQueue = new
PriorityQueue<JobResourcePriority>();
--- End diff --
I don't quite get why this is a queue. It's created in this stage, a bunch
of things added in, and iterated through. Is there any reason not using a
sorted set?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
