Github user jiajunwang commented on a diff in the pull request:

    https://github.com/apache/helix/pull/89#discussion_r116554664
  
    --- Diff: 
helix-core/src/main/java/org/apache/helix/controller/stages/BestPossibleStateCalcStage.java
 ---
    @@ -204,4 +236,28 @@ private MappingCalculator 
getMappingCalculator(Rebalancer rebalancer, String res
     
         return mappingCalculator;
       }
    +
    +  class JobResourcePriority implements Comparable<JobResourcePriority> {
    --- End diff --
    
    From my point of view, this is a priority with a job reference. So call it 
"priority" is fine.
    JobResourceWithPriority is too verbose.
    And ComparableJobResource/JobResource implies that it is another kind of 
job resource class. They seem to be even more confusing.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to