Github user lei-xia commented on a diff in the pull request:

    https://github.com/apache/helix/pull/89#discussion_r119443872
  
    --- Diff: 
helix-core/src/main/java/org/apache/helix/model/InstanceConfig.java ---
    @@ -408,6 +410,18 @@ public void setInstanceEnabledForPartition(String 
resourceName, String partition
         }
       }
     
    +  /**
    +   * Get maximum allowed running task count on this instance
    +   * @return the maximum task count
    +   */
    +  public int getMaxConcurrentTask() {
    --- End diff --
    
    make this config option also available in cluster config? In most of cases, 
user would choose same value for all of its nodes, this makes them easier to 
set just once instead of in each instance config.
    
    If the value is set in both cluster config and some of instance config, the 
value in instance config can take effect.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to