Github user jiajunwang commented on a diff in the pull request:
https://github.com/apache/helix/pull/89#discussion_r116564901
--- Diff: helix-core/src/main/java/org/apache/helix/task/JobRebalancer.java
---
@@ -424,9 +425,15 @@ private ResourceAssignment
computeResourceMapping(String jobResource,
.contains(instance)) {
continue;
}
+ // 1. throttled by job configuration
// Contains the set of task partitions currently assigned to the
instance.
Set<Integer> pSet = entry.getValue();
- int numToAssign = jobCfg.getNumConcurrentTasksPerInstance() -
pSet.size();
+ int jobCfgLimitation = jobCfg.getNumConcurrentTasksPerInstance() -
pSet.size();
--- End diff --
I get your point.
But it is not quite necessary at this moment.
I prefer to split this huge method when there is any re-used logic.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
