narendly commented on a change in pull request #333: Fix issue when client only
sets ANY at cluster level throttle config
URL: https://github.com/apache/helix/pull/333#discussion_r309488920
##########
File path:
helix-core/src/test/java/org/apache/helix/integration/TestPartitionMovementThrottle.java
##########
@@ -42,12 +45,17 @@
import org.apache.helix.model.IdealState.RebalanceMode;
import org.apache.helix.model.Message;
import
org.apache.helix.tools.ClusterVerifiers.BestPossibleExternalViewVerifier;
+import org.apache.helix.tools.ClusterVerifiers.ClusterLiveNodesVerifier;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
import org.testng.Assert;
import org.testng.annotations.AfterMethod;
import org.testng.annotations.BeforeClass;
import org.testng.annotations.Test;
public class TestPartitionMovementThrottle extends ZkStandAloneCMTestBase {
+ private static final Logger LOGGER =
LoggerFactory.getLogger(TestPartitionMovementThrottle.class);
Review comment:
Let's not log in the tests. If you need to debug, use print statements in
your local environment.
And let us use LOG for the logger if you need to use it in other parts of
the codebase.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
