narendly commented on a change in pull request #333: Fix issue when client only sets ANY at cluster level throttle config URL: https://github.com/apache/helix/pull/333#discussion_r310232277
########## File path: helix-core/src/main/java/org/apache/helix/controller/stages/StateTransitionThrottleController.java ########## @@ -99,6 +99,21 @@ public StateTransitionThrottleController(Set<String> resources, ClusterConfig cl } } + // The getter methods are used for debugging and testing purpose Review comment: Yes, you would need to make the relevant fields `protected`. That was implied. `protected` should be good enough as long as we don't make it `public`. The point here is to avoid adding methods that aren't strictly part of the class logic :) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services