jiajunwang commented on a change in pull request #365: Fix RoutingTableProvider
statePropagationLatency metric reporting bug
URL: https://github.com/apache/helix/pull/365#discussion_r309554185
##########
File path:
helix-core/src/main/java/org/apache/helix/common/caches/CurrentStateCache.java
##########
@@ -136,8 +136,8 @@ private void refreshCurrentStatesCache(HelixDataAccessor
accessor,
cachedKeys.retainAll(currentStateKeys);
Map<PropertyKey, CurrentState> newStateCache = Collections.unmodifiableMap(
- refreshProperties(accessor, new ArrayList<>(reloadKeys), new
ArrayList<>(cachedKeys),
- _currentStateCache));
+ refreshProperties(accessor, reloadKeys, new ArrayList<>(cachedKeys),
+ _currentStateCache, reloadKeys));
Review comment:
This looks strange to me... Let's just have a new reloadedKeyList in
addition?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
