jiajunwang commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug URL: https://github.com/apache/helix/pull/365#discussion_r309928848
########## File path: helix-core/src/main/java/org/apache/helix/common/caches/ExternalViewCache.java ########## @@ -95,8 +95,8 @@ public void refresh(HelixDataAccessor accessor) { reloadKeys.removeAll(cachedKeys); Map<PropertyKey, ExternalView> updatedMap = - refreshProperties(accessor, new LinkedList<>(reloadKeys), new ArrayList<>(cachedKeys), - cachedExternalViewMap); + refreshProperties(accessor, reloadKeys, new ArrayList<>(cachedKeys), + cachedExternalViewMap, reloadKeys); Review comment: Same here, can we input the empty list? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services