kaisun2000 commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug URL: https://github.com/apache/helix/pull/365#discussion_r309807277
########## File path: helix-core/src/main/java/org/apache/helix/common/caches/CurrentStateCache.java ########## @@ -136,8 +136,8 @@ private void refreshCurrentStatesCache(HelixDataAccessor accessor, cachedKeys.retainAll(currentStateKeys); Map<PropertyKey, CurrentState> newStateCache = Collections.unmodifiableMap( - refreshProperties(accessor, new ArrayList<>(reloadKeys), new ArrayList<>(cachedKeys), - _currentStateCache)); + refreshProperties(accessor, reloadKeys, new ArrayList<>(cachedKeys), + _currentStateCache, reloadKeys)); Review comment: This is crucial for fixing the bug. We need reloadKeys to be modified to reflect the change in refreshProperties ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services