kaisun2000 commented on a change in pull request #365: Fix RoutingTableProvider
statePropagationLatency metric reporting bug
URL: https://github.com/apache/helix/pull/365#discussion_r310831810
##########
File path:
helix-core/src/main/java/org/apache/helix/common/caches/AbstractDataCache.java
##########
@@ -48,15 +50,17 @@ public AbstractDataCache(ControlContextProvider
controlContextProvider) {
* Selectively fetch Helix Properties from ZK by comparing the version of
local cached one with the one on ZK.
* If version on ZK is newer, fetch it from zk and update local cache.
* @param accessor the HelixDataAccessor
- * @param reloadKeys keys needs to be reload
+ * @param reloadKeysIn keys needs to be reload
Review comment:
ReloadKeysIn means this is the input parameter, it is not changed
Note, later, there is a reloadedKeys, that is the output parameter with all
the keys that are reloaded.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
