jiajunwang commented on a change in pull request #362: The WAGED rebalancer cluster model implementation URL: https://github.com/apache/helix/pull/362#discussion_r310278490
########## File path: helix-core/src/test/java/org/apache/helix/controller/rebalancer/waged/model/TestAssignableReplica.java ########## @@ -0,0 +1,100 @@ +package org.apache.helix.controller.rebalancer.waged.model; + +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +import org.apache.helix.model.ResourceConfig; +import org.testng.Assert; +import org.testng.annotations.Test; + +import java.io.IOException; +import java.util.Collections; +import java.util.HashMap; +import java.util.Map; + +import static org.apache.helix.model.StateModelDefinition.TOP_STATE_PRIORITY; + +public class TestAssignableReplica { + String resourceName = "Resource"; + String partitionNamePrefix = "partition"; + String masterState = "Master"; + int masterPriority = TOP_STATE_PRIORITY; + String slaveState = "Slave"; + int slavePriority = 2; + + @Test + public void testConstructRepliaWithResourceConfig() throws IOException { + // Init assignable replication with a basic config object + Map<String, Integer> capacityDataMapResource1 = new HashMap<>(); + capacityDataMapResource1.put("item1", 3); + capacityDataMapResource1.put("item2", 6); + ResourceConfig testResourceConfigResource = new ResourceConfig(resourceName); + testResourceConfigResource.setPartitionCapacityMap( + Collections.singletonMap(ResourceConfig.DEFAULT_PARTITION_KEY, capacityDataMapResource1)); + + String partitionName = partitionNamePrefix + 1; + AssignableReplica replica = + new AssignableReplica(testResourceConfigResource, partitionName, masterState, + masterPriority); + Assert.assertEquals(replica.getResourceName(), resourceName); Review comment: In that case, we will still need to list all the different parameters. Moreover, if anything new to check in different places, we need to split the method or check redundantly. So I prefer to keep the Asserts listed in the test case. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
