jiajunwang commented on a change in pull request #362: The WAGED rebalancer cluster model implementation URL: https://github.com/apache/helix/pull/362#discussion_r310279995
########## File path: helix-core/src/test/java/org/apache/helix/controller/rebalancer/waged/model/TestClusterContext.java ########## @@ -0,0 +1,93 @@ +package org.apache.helix.controller.rebalancer.waged.model; + +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +import org.apache.helix.HelixException; +import org.apache.helix.controller.dataproviders.ResourceControllerDataProvider; +import org.testng.Assert; +import org.testng.annotations.BeforeClass; +import org.testng.annotations.Test; + +import java.io.IOException; +import java.util.Collections; +import java.util.Map; +import java.util.Set; +import java.util.stream.Collectors; + +import static java.util.stream.Collectors.toSet; + +public class TestClusterContext extends AbstractTestClusterModel { + @BeforeClass + public void initialize() { + super.initialize(); + } + + @Test + public void testNormalUsage() throws IOException { + ResourceControllerDataProvider testCache = setupClusterDataCache(); + Set<AssignableReplica> assignmentSet = generateReplicas(testCache); + + // Test 1 - initialization + ClusterContext context = new ClusterContext(assignmentSet, 2); + + // Note that we leaved some margin for the max estimation. + Assert.assertEquals(context.getEstimatedMaxPartitionCount(), 3); + Assert.assertEquals(context.getEstimatedMaxTopStateCount(), 2); + Assert.assertEquals(context.getAssignmentForFaultZoneMap(), Collections.emptyMap()); + for (String resourceName : _resourceNames) { + Assert.assertEquals(context.getEstimatedMaxPartitionByResource(resourceName), 2); + Assert.assertEquals( + context.getPartitionsForResourceAndFaultZone(_testFaultZoneId, resourceName), + Collections.emptySet()); + } + + // Assign + Map<String, Map<String, Set<String>>> expectedFaultZoneMap = Collections + .singletonMap(_testFaultZoneId, assignmentSet.stream().collect(Collectors + .groupingBy(AssignableReplica::getResourceName, + Collectors.mapping(AssignableReplica::getPartitionName, toSet())))); + + assignmentSet.stream().forEach(r -> context + .addPartitionToFaultZone(_testFaultZoneId, r.getResourceName(), r.getPartitionName())); + Assert.assertEquals(context.getAssignmentForFaultZoneMap(), expectedFaultZoneMap); + + // release + Assert.assertTrue(expectedFaultZoneMap.get(_testFaultZoneId).get(_resourceNames.get(0)) Review comment: This is a typo. Good catch! Should check the next line. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
