Sent from my iPhone
> On Jan 16, 2022, at 8:31 PM, Nicholas Nezis <[email protected]> wrote:
>
> Helm chart cleanup PR. https://github.com/apache/incubator-heron/pull/3758
>
> I added the LICENSE, NOTICE and DISCLAIMER files in the Chart.
>
> The license was already in the Chart.yaml, but I wasn't able to get Helm to
> keep it there. It seems to strip all comments from the resulting
> Chart.yaml. Hopefully this is ok. It seems to match what Apache Tika is
> doing in their Chart.yaml which also results in the stripped down
> Chart.yaml in their published Helm chart.
> Tika Chart.yaml: https://github.com/apache/tika-helm/blob/main/Chart.yaml
> Helm chart: https://apache.jfrog.io/artifactory/tika/tika/tika-1.26.tgz
Since Chart.yaml is generated then it’s ok not have the license header.
Regards,
Dave
>
>
>
>
>> On Fri, Jan 14, 2022 at 6:55 PM Josh Fischer <[email protected]> wrote:
>>
>> Well done, Nick.
>>
>>> On Fri, Jan 14, 2022 at 4:39 PM Dave Fisher <[email protected]> wrote:
>>>
>>>
>>>
>>>> On Jan 14, 2022, at 2:33 PM, Nicholas Nezis <[email protected]>
>>> wrote:
>>>>
>>>> Awesome thank you Dave. Yes for Helm and HeronPy it is the first time
>> we
>>>> are releasing them (at least since I've joined the team), so this is
>>>> necessary feedback.
>>>>
>>>> We will work to resolve these issues. For now as the release manager,
>> for
>>>> this release, should I consider this vote to have ended and we can
>>> re-vote
>>>> once the issues are resolved?
>>>
>>> OK with me.
>>>
>>>>
>>>> On Fri, Jan 14, 2022 at 4:02 PM Dave Fisher <[email protected]> wrote:
>>>>
>>>>> +1 (binding) on everything except HeronPy and Helm. I’m -0 on those. I
>>>>> think that the fixes are simple it is up to the Nicholas to decide if
>> he
>>>>> wants to re-roll with those fixed.
>>>>>
>>>>>> On Jan 14, 2022, at 11:20 AM, Nicholas Nezis <
>> [email protected]
>>>>
>>>>> wrote:
>>>>>>
>>>>>> Dave,
>>>>>>
>>>>>> I think the released artifacts are as follows:
>>>>>
>>>>> All packages have proper signatures and checksums.
>>>>>
>>>>>>
>>>>>> 1. Source package (src.tar.gz)
>>>>>
>>>>> LICENSE and NOTICE look good. AFAICT the headers are good in the
>> source.
>>>>>
>>>>> Starting local Bazel server and connecting to it...
>>>>> WARNING:
>>>>>
>>>
>> /Users/davewave/Development/heron/0.20.5/incubator-heron-0.20.5-incubating/heron/healthmgr/tests/java/BUILD:52:13:
>>>>> in srcs attribute of java_library rule
>>>>> //heron/healthmgr/tests/java:healthmgr-tests: please do not import
>>>>>
>>>
>> '//heron/healthmgr/src/java:org/apache/heron/healthmgr/HealthManager.java'
>>>>> directly. You should either move the file to this package or depend on
>>> an
>>>>> appropriate rule there. Since this rule was created by the macro
>>>>> 'java_library', the error might have been caused by the macro
>>> implementation
>>>>>
>>>>> My Bazel build failed due to PEX error:
>>>>> pex.jobs.Error: Executing
>>>>>
>>>
>> /private/var/tmp/_bazel_davewave/0be66f73022bc599dc29ee339806b3e2/execroot/org_apache_heron/.pex/venvs/8c07b930c4cbc1f49e57b433419d6738f2565399/fe6e0b61575ee08b291980cb87e33ca122778c45/pex
>>>>> --disable-pip-version-check --no-python-version-warning
>> --exists-action
>>> a
>>>>> --isolated -q --no-cache-dir wheel --no-deps --wheel-dir
>>>>>
>>>
>> /var/folders/n2/qyvr5jv11bg1qf33fzx8ccv80000gn/T/tmp_32nhm85/built_wheels/sdists/PyYAML-3.13.tar.gz/22f95fe2f5ef29ab17110f92c7186e2cfde6b419/cp39-cp39.e717ce57461546e0b38b5ba53be3a270
>>>>>
>>>
>> /var/folders/n2/qyvr5jv11bg1qf33fzx8ccv80000gn/T/tmp_32nhm85/usr.local.cellar.pyt...@3.9.3.9.5.frameworks.python.framework.versions.3.9.bin.python3.9
>>> /PyYAML-3.13.tar.gz
>>>>> --index-url https://pypi.org/simple --retries 5 --timeout 15 failed
>>> with 1
>>>>>
>>>>> % python --version
>>>>> Python 2.7.16
>>>>> % python3 --version
>>>>> Python 3.9.5
>>>>>
>>>>>
>>>>>> 2. Convenience binaries for Maven artifacts (heron-artifacts)
>>>>>> 1. These should also be uploaded to a Maven repo
>>>>>
>>>>> (a) For heron-simulator-0.20.5-incubating.jar the META-INF/LICENSE.txt
>>> is
>>>>> missing the Apache License.
>>>>> The pom did have the correct license.
>>>>>
>>>>> Is there a reason the source contains Apache Commons CLI and Lang3
>>> source
>>>>> code?
>>>>>
>>>>> (b) For heron-api, heron-kafka-bolt, heron-kafka-spout, heron-spi, and
>>>>> heron-storm - there are no META-INF/LICENSE and NOTICE files.
>>>>>
>>>>>> 3. Convenience binaries for installation per OS (heron-install)
>>>>>
>>>>> These are OK.
>>>>>
>>>>>> 4. Convenience binary for HeronPy
>>>>>
>>>>> Actually this is python source. It is missing LICENSE and NOTICE.
>>>>>
>>>>> In heronpy-0.20.5-incubating % more PKG-INFO
>>>>> Author: Heron Team. <- Apache Heron (incubating)
>>>>> Author-email: [email protected] <- [email protected]
>>>>> License: UNKNOWN <- Apache License v2.0
>>>>>
>>>>>
>>>>>> 1. we also upload the convenience binaries to PyPi repo
>>>>>> 5. Convenience binary for Helm chart (helm folder)
>>>>>
>>>>> LICENSE and NOTICE are missing
>>>>> Chart.yaml is missing license header,
>>>>>
>>>>>> 1. Also published to the apache.jfrog.org Helm repository
>>>>>>
>>>>>> Are we over complicating our release process by including all of
>> these?
>>>>>
>>>>> No.
>>>>>
>>>>>> Should we focus on releasing the source artifact and release
>>> un-official
>>>>>> convenience artifacts to the external repos (i.e. Maven, PyPi, Helm,
>>>>>> DockerHub)?
>>>>>
>>>>> The sooner you do these correctly as Apache releases, the sooner Heron
>>> can
>>>>> graduate.
>>>>>
>>>>> Regards,
>>>>> Dave
>>>>>
>>>>>>
>>>>>> On Fri, Jan 14, 2022 at 1:56 PM Dave Fisher <[email protected]> wrote:
>>>>>>
>>>>>>> The directory
>>>>>>>
>>>>>
>>>
>> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.5-incubating-rc1/
>>>>>>> contains many other artifacts. Does the PPMC intend to release those
>>> as
>>>>>>> well?
>>>>>>>
>>>>>>> If yes then the signatures, checksums, LICENSE and NOTICE must be
>>>>> checked.
>>>>>>>
>>>>>>>> On Jan 10, 2022, at 8:14 PM, Nicholas Nezis <
>>> [email protected]>
>>>>>>> wrote:
>>>>>>>>
>>>>>>>> Hello Heron Community,
>>>>>>>>
>>>>>>>> This is a call for a vote to the 1st release candidate for Apache
>>>>> Heron,
>>>>>>>> version 0.20.5-incubating.
>>>>>>>> We request project mentors (binded) as well as all contributors
>>>>>>> (unbinded)
>>>>>>>> and users to review and vote on this incubator release.
>>>>>>>>
>>>>>>>> * The tag to be voted upon:
>> fd30626d70e3cc3284dcc527f9d0883f42ff1157
>>>>>>>> The full list of changes and release notes are available
>>>>>>>> at:
>>>>>>>
>>>>>
>>>
>> https://github.com/apache/incubator-heron/releases/tag/0.20.5-incubating-rc1
>>>>>>>>
>>>>>>>> Files can be found in dist.apache.org
>>>>>>>> Source:
>>>>>>>
>>>>>
>>>
>> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.5-incubating-rc1/heron-0.20.5-incubating-src.tar.gz
>>>>>>>> SHA-512 checksums:
>>>>>>>
>>>>>
>>>
>> https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.5-incubating-rc1/heron-0.20.5-incubating-src.tar.gz.sha512
>>>>>>>>
>>>>>>>>
>>>>>>>> Please download the source package, and follow the below steps from
>>>>>>>> the root folder of the heron code base. Note that currently Bazel
>>>>>>>> 4.1.0 is required to build this version and approximate build time
>> is
>>>>>>>> 45 minutes.
>>>>>>>> # check that Bazel and other dependencies are setup correctly
>>>>>>>> ./bazel_configure.py
>>>>>>>>
>>>>>>>>
>>>>>>>> To build an install script for your desired platform (debian, and
>>>>>>>> centos are supported for this release) you may run the following
>>>>>>>> command.
>>>>>>>> for Debian10
>>>>>>>> $ bazel build --config=debian_nostyle scripts/packages:binpkgsfor
>>>>>>>> Ubuntu18.04/Ubuntu20.04
>>>>>>>> $ bazel build --config=ubuntu_nostyle scripts/packages:binpkgs
>>>>>>>> for CentOS7
>>>>>>>> $ bazel build --config=centos_nostyle scripts/packages:binpkgs
>>>>>>>>
>>>>>>>> To execute and install Heron from an install script you can follow
>>> the
>>>>>>>> steps below:
>>>>>>>>
>>>>>>>>
>>>>>>>> $ chmod +x heron-install-0.20.5-incubating-{distro}.sh
>>>>>>>> $ ./heron-install-0.20.5-incubating-{distro}.sh --user
>>>>>>>>
>>>>>>>> From here you should find disclaimers and other files in your
>>> ~/.heron
>>>>>>>> directory.
>>>>>>>> ls ~/.heron/
>>>>>>>>
>>>>>>>> DISCLAIMER NOTICE conf/ etc/ include/
>>>>>>>> release.yaml
>>>>>>>>
>>>>>>>> LICENSE bin/ dist/ examples/ lib/
>>>>>>>>
>>>>>>>>
>>>>>>>> or refer to the compiling
>>>>>>>> guidehttps://
>>> heron.incubator.apache.org/docs/next/compiling-overview/
>>>>>>>> to setup the environment, build and run locally.
>>>>>>>>
>>>>>>>> After Bazel is set up and works correctly, you can use these
>> release
>>>>>>> check
>>>>>>>> scripts as well.
>>>>>>>
>>>>>
>>>
>> https://github.com/apache/incubator-heron/blob/master/scripts/release_check/README.md#run-individual-release-checks
>>>>>>>> to verify the build. The vote will be open for at least 72 hours
>> or
>>>>>>> until
>>>>>>>> the necessary number of votes are reached.
>>>>>>>>
>>>>>>>> Please vote accordingly:
>>>>>>>> [ ] +1 approve
>>>>>>>> [ ] +0 no opinion
>>>>>>>> [ ] -1 disapprove with the reason
>>>>>>>>
>>>>>>>> Thank you,
>>>>>>>>
>>>>>>>> The Apache Heron (Incubating) Team
>>>>>>>
>>>>>>>
>>>>>
>>>>>
>>>
>>> --
>> Sent from A Mobile Device
>>
