[
https://issues.apache.org/jira/browse/HIVE-1526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12966391#action_12966391
]
Carl Steinbach commented on HIVE-1526:
--------------------------------------
bq. A new problem is that if you run ant -Dthrift.home=<thrift-0.5-home>
thriftif and then run ant package, there will be compilation error.
I was unable to reproduce the compilation error. Are you sure that you're using
Thrift 0.5.0? Did you apply the complete patch before executing the thriftif
target? Which files were modified as a result of executing the thriftif target?
bq. A similar problem can be reproduced by removing all svn deleted files under
serde/src and run ant package.
I don't think I understand what you did. How can you remove files that were
already svn deleted? Or are you saying that you did something similar to "rm
-rf serde/src/gen-*"? If so that's going to produce errors because in the
process you also blew away protobuf generated code located in the
serde/src/gen-java directory.
bq. I debugged it a little bit and found it may be related to the thrift
generated java and java:bean under serde.
The code in serde/src/gen-java is protobuf code, not Thrift code. This
directory used to contain Thrift generated code, but that code now gets placed
in the gen-javabean directory. If this directory contains any Thrift code then
I think the patch was not applied correctly.
> Hive should depend on a release version of Thrift
> -------------------------------------------------
>
> Key: HIVE-1526
> URL: https://issues.apache.org/jira/browse/HIVE-1526
> Project: Hive
> Issue Type: Task
> Components: Build Infrastructure, Clients
> Reporter: Carl Steinbach
> Assignee: Carl Steinbach
> Fix For: 0.7.0
>
> Attachments: compile.err, HIVE-1526-complete.4.patch.txt,
> HIVE-1526-complete.5.patch.txt, HIVE-1526-no-codegen.3.patch.txt,
> HIVE-1526-no-codegen.4.patch.txt, HIVE-1526-no-codegen.5.patch.txt,
> HIVE-1526.2.patch.txt, HIVE-1526.3.patch.txt, hive-1526.txt, libfb303.jar,
> libthrift.jar, serde2_test.patch, svn_rm.sh, thrift-0.5.0.jar,
> thrift-fb303-0.5.0.jar
>
>
> Hive should depend on a release version of Thrift, and ideally it should use
> Ivy to resolve this dependency.
> The Thrift folks are working on adding Thrift artifacts to a maven repository
> here: https://issues.apache.org/jira/browse/THRIFT-363
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
