[ 
https://issues.apache.org/jira/browse/HIVE-1526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12968369#action_12968369
 ] 

Ning Zhang commented on HIVE-1526:
----------------------------------

Hi Carl, the latest patch has a compilation error building odbc (ant 
-Dthrift.home=... compile-cpp). I think it is due to the fact that the thrift 
generated code are under src/gen/thrift/gen-cpp etc. You may need to change the 
Makefile to reflect that. 

Also there are still exceptions on dynamic serde. When you run 'ant 
-Dthrift.home=... -Dtestcase=TestDynamicSerde' it throws 
org.apache.thrift.transport.TTransportException (they also appear in the 
test.log I uploaded before) although at last ant showed 'BUILD SUCCESSFUL'. In 
the trunk there is no such exception. 

I agree that dynamic serde itself may not as important and we are considering 
to deprecate it, but it is one of the few (if not the only) test cases in our 
unit tests that uses the thrift library. I think we should find out the reason 
why there are exceptions before we can commit the changes. 

> Hive should depend on a release version of Thrift
> -------------------------------------------------
>
>                 Key: HIVE-1526
>                 URL: https://issues.apache.org/jira/browse/HIVE-1526
>             Project: Hive
>          Issue Type: Task
>          Components: Build Infrastructure, Clients
>            Reporter: Carl Steinbach
>            Assignee: Carl Steinbach
>             Fix For: 0.7.0
>
>         Attachments: compile.err, HIVE-1526-complete.4.patch.txt, 
> HIVE-1526-complete.5.patch.txt, HIVE-1526-complete.6.patch.txt, 
> HIVE-1526-no-codegen.3.patch.txt, HIVE-1526-no-codegen.4.patch.txt, 
> HIVE-1526-no-codegen.5.patch.txt, HIVE-1526-no-codegen.6.patch.txt, 
> HIVE-1526.2.patch.txt, HIVE-1526.3.patch.txt, hive-1526.txt, libfb303.jar, 
> libthrift.jar, serde2_test.patch, svn_rm.sh, test.log, thrift-0.5.0.jar, 
> thrift-fb303-0.5.0.jar
>
>
> Hive should depend on a release version of Thrift, and ideally it should use 
> Ivy to resolve this dependency.
> The Thrift folks are working on adding Thrift artifacts to a maven repository 
> here: https://issues.apache.org/jira/browse/THRIFT-363

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to