+1 for option 2. In general, we as a community should be nice to all contributors, and should avoid doing things that make contributors not comfortable, even that requires some work from committers. Sometimes it is especially true for new contributors, like we need to be more patience for new people. It seems a free style and contribution focused environment would be better to encourage people to do more contributions of different kinds.
thanks -yongqiang On Wed, Jan 19, 2011 at 6:37 PM, Namit Jain <nj...@fb.com> wrote: > > > > It would be good to have a policy for submitting a new patch for review. > If the patch is small, usually it is pretty easy to review.But, if it large, > a GUI like reviewboard (https://reviews.apache.org) makes it easy. > > So, going forward, I would like to propose either of the following. > > 1. All patches must go through reviewboard > 2. If a contributor/reviewer creates a reviewboard request, > all subsequent review requests should go through the reviewboard. > > > I would personally vote for 2., since for small patches, we don’t really need > a > reviewboard. > > But, please vote, and based on that, we can come up with a policy. > Let us know, if you think of some other option. > > Thanks, > -namit > >
