> On 2011-04-25 23:20:59, Ning Zhang wrote: > > trunk/conf/hive-default.xml, line 1042 > > <https://reviews.apache.org/r/665/diff/1/?file=17317#file17317line1042> > > > > can you make the indentation consistent with the other property > > elements?
It shows the same indentation on my local. So it might just be an review board display issue. > On 2011-04-25 23:20:59, Ning Zhang wrote: > > trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java, > > line 1203 > > <https://reviews.apache.org/r/665/diff/1/?file=17321#file17321line1203> > > > > So after adding this, does the block-level merge after INSERT OVERWRITE > > be automatically supported? No. Not automatically supported. We still need to do some work there. but it is a separate issue. - Yongqiang ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/665/#review554 ----------------------------------------------------------- On 2011-04-25 22:47:17, Yongqiang He wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/665/ > ----------------------------------------------------------- > > (Updated 2011-04-25 22:47:17) > > > Review request for hive. > > > Summary > ------- > > alter table concatenate fails and deletes data > > It is because the number of reducers is set to -1. > > In this patch, it is set to zero. > > Also added a move task as the child task of the merge task. added a conf to > control whether to check index or not, and add the job name for the merge job. > > > This addresses bug HIVE-2125. > https://issues.apache.org/jira/browse/HIVE-2125 > > > Diffs > ----- > > trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1096599 > trunk/conf/hive-default.xml 1096599 > trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 1096599 > trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Task.java 1096599 > > trunk/ql/src/java/org/apache/hadoop/hive/ql/io/rcfile/merge/BlockMergeTask.java > 1096599 > trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java > 1096599 > trunk/ql/src/test/queries/clientnegative/alter_merge_index.q PRE-CREATION > trunk/ql/src/test/queries/clientpositive/alter_merge_index.q PRE-CREATION > trunk/ql/src/test/results/clientnegative/alter_merge_index.q.out > PRE-CREATION > trunk/ql/src/test/results/clientpositive/alter_merge_index.q.out > PRE-CREATION > > Diff: https://reviews.apache.org/r/665/diff > > > Testing > ------- > > > Thanks, > > Yongqiang > >
