> On 2011-04-26 05:33:19, Carl Steinbach wrote: > > trunk/ql/src/test/queries/clientpositive/alter_merge_index.q, line 1 > > <https://reviews.apache.org/r/665/diff/1/?file=17323#file17323line1> > > > > Please add some comments here too.
Carl, what kind of comments do you want here? > On 2011-04-26 05:33:19, Carl Steinbach wrote: > > trunk/ql/src/test/queries/clientnegative/alter_merge_index.q, line 1 > > <https://reviews.apache.org/r/665/diff/1/?file=17322#file17322line1> > > > > Please add some comments explaining what it is that you're testing, > > e.g. why is this a negative test? Why is expected to fail? >>why is this a negative test? Why is expected to fail? should i put a positive test on a negative test dir? Should we explain all test cases in client negative dir? Come on, please put some positive suggestions. - Yongqiang ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/665/#review557 ----------------------------------------------------------- On 2011-04-25 22:47:17, Yongqiang He wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/665/ > ----------------------------------------------------------- > > (Updated 2011-04-25 22:47:17) > > > Review request for hive. > > > Summary > ------- > > alter table concatenate fails and deletes data > > It is because the number of reducers is set to -1. > > In this patch, it is set to zero. > > Also added a move task as the child task of the merge task. added a conf to > control whether to check index or not, and add the job name for the merge job. > > > This addresses bug HIVE-2125. > https://issues.apache.org/jira/browse/HIVE-2125 > > > Diffs > ----- > > trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1096599 > trunk/conf/hive-default.xml 1096599 > trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 1096599 > trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Task.java 1096599 > > trunk/ql/src/java/org/apache/hadoop/hive/ql/io/rcfile/merge/BlockMergeTask.java > 1096599 > trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java > 1096599 > trunk/ql/src/test/queries/clientnegative/alter_merge_index.q PRE-CREATION > trunk/ql/src/test/queries/clientpositive/alter_merge_index.q PRE-CREATION > trunk/ql/src/test/results/clientnegative/alter_merge_index.q.out > PRE-CREATION > trunk/ql/src/test/results/clientpositive/alter_merge_index.q.out > PRE-CREATION > > Diff: https://reviews.apache.org/r/665/diff > > > Testing > ------- > > > Thanks, > > Yongqiang > >
