[
https://issues.apache.org/jira/browse/HIVE-1537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13056731#comment-13056731
]
jirapos...@reviews.apache.org commented on HIVE-1537:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/973/
-----------------------------------------------------------
Review request for hive, Ashutosh Chauhan, Ning Zhang, and Amareshwari
Sriramadasu.
Summary
-------
* Removed alter database code from previous patch.
* Updated create database to gracefully fail if database dir cannot be created
(very close to Devaraj's patch)
This addresses bug HIVE-1537.
https://issues.apache.org/jira/browse/HIVE-1537
Diffs
-----
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java
1140495
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
1140495
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/Warehouse.java
1140495
trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java
1140495
trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/StatsTask.java 1140495
trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java
1140495
trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g 1140495
trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/ImportSemanticAnalyzer.java
1140495
trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
1140495
trunk/ql/src/test/org/apache/hadoop/hive/ql/metadata/TestHive.java 1140495
trunk/ql/src/test/queries/clientpositive/database_location.q PRE-CREATION
trunk/ql/src/test/results/clientpositive/database_location.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/973/diff
Testing
-------
Updated testDatabaseLocation() in TestHiveMetaStore() to test for negative case.
Ran entire unit test and it went through fine for me.
Thanks,
Thiruvel
Thanks,
Thiruvel
> Allow users to specify LOCATION in CREATE DATABASE statement
> ------------------------------------------------------------
>
> Key: HIVE-1537
> URL: https://issues.apache.org/jira/browse/HIVE-1537
> Project: Hive
> Issue Type: New Feature
> Components: Metastore
> Reporter: Carl Steinbach
> Assignee: Thiruvel Thirumoolan
> Attachments: HIVE-1537.patch, hive-1537.metastore.part.patch
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
