[
https://issues.apache.org/jira/browse/HIVE-1537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13060523#comment-13060523
]
jirapos...@reviews.apache.org commented on HIVE-1537:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/949/
-----------------------------------------------------------
(Updated 2011-07-06 12:14:34.148278)
Review request for hive, Ning Zhang and Amareshwari Sriramadasu.
Changes
-------
Thanks Ashutosh, updated patch with your comments. Not sure whats the benefit
of embedding the whole chunk inside transactions, so have not done it.
Thanks!
Thiruvel
Summary
-------
Usage:
create database location 'path1';
alter database location 'path2';
After 'alter', only newly created tables will be located under the new
location. Tables created before 'alter' will be under 'path1'.
Notes:
------
1. I have moved getDefaultDatabasePath() to HiveMetaStore and made it private.
There should only be one API to obtain the location of a database and it has to
accept 'Database' as an arg and hence the new method in Warehouse
'getDatabasePath()' and similarly 'getTablePath()'. The usages of older API
also has been changed. Hope that should be fine.
2. One could argue why have getDatabasePath() as location can be obtained by
db.getLocationUri(). I wanted to retain this method to do any additional
processing if necessary (getDns or whatever).
This addresses bug HIVE-1537.
https://issues.apache.org/jira/browse/HIVE-1537
Diffs (updated)
-----
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java
1143322
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
1143322
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/Warehouse.java
1143322
trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java
1143322
trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/StatsTask.java 1143322
trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java
1143322
trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g 1143322
trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/ImportSemanticAnalyzer.java
1143322
trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
1143322
trunk/ql/src/test/org/apache/hadoop/hive/ql/metadata/TestHive.java 1143322
trunk/ql/src/test/queries/clientpositive/database_location.q PRE-CREATION
trunk/ql/src/test/results/clientpositive/database_location.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/949/diff
Testing
-------
1. Updated TestHiveMetaStore.java for testing the functionality - database
creation, alteration and table's locations as TestCliDriver outputs ignore
locations.
2. Added database_location.q for testing the grammar primarily.
Thanks,
Thiruvel
Thanks,
Thiruvel
> Allow users to specify LOCATION in CREATE DATABASE statement
> ------------------------------------------------------------
>
> Key: HIVE-1537
> URL: https://issues.apache.org/jira/browse/HIVE-1537
> Project: Hive
> Issue Type: New Feature
> Components: Metastore
> Reporter: Carl Steinbach
> Assignee: Thiruvel Thirumoolan
> Attachments: HIVE-1537.patch, hive-1537.metastore.part.patch
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
