[ https://issues.apache.org/jira/browse/HIVE-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13067878#comment-13067878 ]
jirapos...@reviews.apache.org commented on HIVE-2128: ----------------------------------------------------- ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1010/#review1112 ----------------------------------------------------------- ql/src/java/org/apache/hadoop/hive/ql/index/HiveIndexQueryContext.java <https://reviews.apache.org/r/1010/#comment2271> Why was this comment truncated? ql/src/test/queries/clientpositive/index_auto_mult_tables.q <https://reviews.apache.org/r/1010/#comment2273> All of these SELECT statements need ORDER BY for determinism. - John On 2011-07-19 03:15:17, Syed Albiz wrote: bq. bq. ----------------------------------------------------------- bq. This is an automatically generated e-mail. To reply, visit: bq. https://reviews.apache.org/r/1010/ bq. ----------------------------------------------------------- bq. bq. (Updated 2011-07-19 03:15:17) bq. bq. bq. Review request for hive and John Sichi. bq. bq. bq. Summary bq. ------- bq. bq. Grab the indexed tables during optimized query generation, grab the associated path URIs, and keep those around in the Configuration object. When the job is passed to ExecDriver, this data is extracted and used in HiveIndexedInputFormat to decide whether to use the index file or delegate to the parent (HiveInputFormat) class. Not sure if this is robust. bq. bq. bq. This addresses bug HIVE-2128. bq. https://issues.apache.org/jira/browse/HIVE-2128 bq. bq. bq. Diffs bq. ----- bq. bq. ql/src/test/results/clientpositive/index_auto_self_join.q.out PRE-CREATION bq. ql/src/test/results/clientpositive/index_auto_mult_tables_compact.q.out PRE-CREATION bq. ql/src/test/queries/clientpositive/index_auto_self_join.q PRE-CREATION bq. ql/src/test/results/clientpositive/index_auto_mult_tables.q.out PRE-CREATION bq. ql/src/java/org/apache/hadoop/hive/ql/plan/MapredWork.java a03a9a6 bq. ql/src/test/queries/clientpositive/index_auto_mult_tables.q PRE-CREATION bq. ql/src/test/queries/clientpositive/index_auto_mult_tables_compact.q PRE-CREATION bq. ql/src/java/org/apache/hadoop/hive/ql/index/HiveIndexResult.java b9b586e bq. ql/src/java/org/apache/hadoop/hive/ql/index/HiveIndexedInputFormat.java f1ee95d bq. ql/src/java/org/apache/hadoop/hive/ql/index/bitmap/BitmapIndexHandler.java 61bbbf5 bq. ql/src/java/org/apache/hadoop/hive/ql/index/compact/CompactIndexHandler.java 7c91946 bq. ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/index/IndexWhereProcessor.java dbc489f bq. ql/src/java/org/apache/hadoop/hive/ql/index/HiveIndexQueryContext.java 617723e bq. bq. Diff: https://reviews.apache.org/r/1010/diff bq. bq. bq. Testing bq. ------- bq. bq. added new testcase index_auto_mult_tables.q bq. bq. bq. Thanks, bq. bq. Syed bq. bq. > Automatic Indexing with multiple tables > --------------------------------------- > > Key: HIVE-2128 > URL: https://issues.apache.org/jira/browse/HIVE-2128 > Project: Hive > Issue Type: Improvement > Components: Indexing > Affects Versions: 0.8.0 > Reporter: Russell Melick > Assignee: Syed S. Albiz > Attachments: HIVE-2128.1.patch, HIVE-2128.1.patch, HIVE-2128.2.patch, > HIVE-2128.4.patch, HIVE-2128.5.patch > > > Make automatic indexing work with jobs which access multiple tables. We'll > probably need to modify the way that the index input format works in order to > associate index formats/files with specific tables. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira