[
https://issues.apache.org/jira/browse/HIVE-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13069299#comment-13069299
]
jirapos...@reviews.apache.org commented on HIVE-2128:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1010/
-----------------------------------------------------------
(Updated 2011-07-21 23:52:23.929900)
Review request for hive and John Sichi.
Changes
-------
Added order by to testcases. This revealed an existing bug where we would walk
the entire operator tree for each task in the task tree in
IndexWhereTaskDispatcher. I amended this to only walk the subset of the
operator tree in the current task.
Summary
-------
Grab the indexed tables during optimized query generation, grab the associated
path URIs, and keep those around in the Configuration object. When the job is
passed to ExecDriver, this data is extracted and used in HiveIndexedInputFormat
to decide whether to use the index file or delegate to the parent
(HiveInputFormat) class. Not sure if this is robust.
This addresses bug HIVE-2128.
https://issues.apache.org/jira/browse/HIVE-2128
Diffs (updated)
-----
ql/src/test/results/clientpositive/index_bitmap_auto_partitioned.q.out
4c9efd1
ql/src/test/results/clientpositive/index_auto_self_join.q.out PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/index/HiveIndexResult.java b9b586e
ql/src/java/org/apache/hadoop/hive/ql/index/HiveIndexedInputFormat.java
f1ee95d
ql/src/java/org/apache/hadoop/hive/ql/index/bitmap/BitmapIndexHandler.java
61bbbf5
ql/src/java/org/apache/hadoop/hive/ql/index/compact/CompactIndexHandler.java
7c91946
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/index/IndexWhereProcessor.java
dbc489f
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/index/IndexWhereTaskDispatcher.java
da084f6
ql/src/java/org/apache/hadoop/hive/ql/plan/MapredWork.java a03a9a6
ql/src/test/queries/clientpositive/index_auto_mult_tables.q PRE-CREATION
ql/src/test/queries/clientpositive/index_auto_mult_tables_compact.q
PRE-CREATION
ql/src/test/queries/clientpositive/index_auto_self_join.q PRE-CREATION
ql/src/test/results/clientpositive/index_auto_mult_tables.q.out PRE-CREATION
ql/src/test/results/clientpositive/index_auto_mult_tables_compact.q.out
PRE-CREATION
Diff: https://reviews.apache.org/r/1010/diff
Testing
-------
added new testcase index_auto_mult_tables.q
Thanks,
Syed
> Automatic Indexing with multiple tables
> ---------------------------------------
>
> Key: HIVE-2128
> URL: https://issues.apache.org/jira/browse/HIVE-2128
> Project: Hive
> Issue Type: Improvement
> Components: Indexing
> Affects Versions: 0.8.0
> Reporter: Russell Melick
> Assignee: Syed S. Albiz
> Attachments: HIVE-2128.1.patch, HIVE-2128.1.patch, HIVE-2128.2.patch,
> HIVE-2128.4.patch, HIVE-2128.5.patch, HIVE-2128.6.patch
>
>
> Make automatic indexing work with jobs which access multiple tables. We'll
> probably need to modify the way that the index input format works in order to
> associate index formats/files with specific tables.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
