----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1441/#review1368 -----------------------------------------------------------
trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java <https://reviews.apache.org/r/1441/#comment3136> Please add these definitions to hive-default.xml along with a description for each property. trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java <https://reviews.apache.org/r/1441/#comment3140> These are initialized in the constructor. Please don't also initialize them here. trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java <https://reviews.apache.org/r/1441/#comment3137> Please run checkstyle and correct any violations introduced by your changes. trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java <https://reviews.apache.org/r/1441/#comment3142> Create a static final variable for the 20 char length limit. - Carl On 2011-08-09 22:40:56, sameerm wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/1441/ > ----------------------------------------------------------- > > (Updated 2011-08-09 22:40:56) > > > Review request for hive and Ning Zhang. > > > Summary > ------- > > Default behavior will be as before. > Adding new Hive conf vars to make the column names include the aggregation > function and params. > > > This addresses bug HIVE-1916. > https://issues.apache.org/jira/browse/HIVE-1916 > > > Diffs > ----- > > trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1155181 > trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java > 1155181 > trunk/ql/src/test/queries/clientpositive/autogen_colname.q PRE-CREATION > trunk/ql/src/test/results/clientpositive/autogen_colname.q.out PRE-CREATION > > Diff: https://reviews.apache.org/r/1441/diff > > > Testing > ------- > > Added new query file with expected results. All unit tests pass > > > Thanks, > > sameerm > >
