----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1441/#review1464 -----------------------------------------------------------
Ship it! LGTM - Ning On 2011-08-15 20:09:08, sameerm wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/1441/ > ----------------------------------------------------------- > > (Updated 2011-08-15 20:09:08) > > > Review request for hive and Ning Zhang. > > > Summary > ------- > > Default behavior will be as before. > Adding new Hive conf vars to make the column names include the aggregation > function and params. > > > This addresses bug HIVE-1916. > https://issues.apache.org/jira/browse/HIVE-1916 > > > Diffs > ----- > > trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1157970 > trunk/conf/hive-default.xml 1157970 > trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java > 1157970 > trunk/ql/src/test/queries/clientpositive/autogen_colalias.q PRE-CREATION > trunk/ql/src/test/results/clientpositive/autogen_colalias.q.out > PRE-CREATION > > Diff: https://reviews.apache.org/r/1441/diff > > > Testing > ------- > > Added new query file with expected results. All unit tests pass > > > Thanks, > > sameerm > >
