----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29807/#review68878 -----------------------------------------------------------
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java <https://reviews.apache.org/r/29807/#comment113391> Shouldn't "long" & "LONG" be included in the names "hive.metastore.server.running.method.timeout" & "METASTORE_SERVER_RUNNING_METHOD_TIMEOUT"? Also, please specify the JIRA number (HIVE-9253) in this review request, either under Bugs in the Information section or in the Summary, or both. - Lefty Leverenz On Jan. 21, 2015, 5:49 a.m., Dong Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29807/ > ----------------------------------------------------------- > > (Updated Jan. 21, 2015, 5:49 a.m.) > > > Review request for hive. > > > Repository: hive-git > > > Description > ------- > > MetaStore server should support timeout for long running requests > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 8264b16 > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > 2db90cc > metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java > 564ac8b > metastore/src/java/org/apache/hadoop/hive/metastore/RetryingHMSHandler.java > 01ad36a > metastore/src/java/org/apache/hadoop/hive/metastore/RuntimeTimeout.java > PRE-CREATION > > metastore/src/java/org/apache/hadoop/hive/metastore/RuntimeTimeoutException.java > PRE-CREATION > > metastore/src/java/org/apache/hadoop/hive/metastore/SessionPropertiesListener.java > PRE-CREATION > > metastore/src/test/org/apache/hadoop/hive/metastore/TestHiveMetaStoreTimeout.java > PRE-CREATION > metastore/src/test/org/apache/hadoop/hive/metastore/TestRuntimeTimeout.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/29807/diff/ > > > Testing > ------- > > UT passed > > > Thanks, > > Dong Chen > >