> On Jan. 28, 2015, 8:40 p.m., Thejas Nair wrote: > > ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java, line 1404 > > <https://reviews.apache.org/r/29900/diff/2/?file=825431#file825431line1404> > > > > I have seen at least another place where we have a test timestamp > > getting injected. I might make sense to use some kind of getTimestamp class > > that can be customized to give a specific timestamp. > > But this does not have to be addressed in this jira. > > Jason Dere wrote: > Where does this occur?
in 'show grants' , it shows the timestamp when the grant was made, there is code to return -1 for timestamp in the test mode. > On Jan. 28, 2015, 8:40 p.m., Thejas Nair wrote: > > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFCurrentDate.java, > > line 32 > > <https://reviews.apache.org/r/29900/diff/2/?file=825432#file825432line32> > > > > looks like we can consider this to be deterministic, since the value > > does not change within a query. > > Jason Dere wrote: > ok, will change. If we ever have a new descriptor to specify > deterministic within the same query but different for different queries, this > would fit the description. Would be needed for stuff like determining > suitability of queries for materialized views. good point about materialized views - Thejas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29900/#review70062 ----------------------------------------------------------- On Jan. 28, 2015, 11:22 p.m., Jason Dere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29900/ > ----------------------------------------------------------- > > (Updated Jan. 28, 2015, 11:22 p.m.) > > > Review request for hive and Thejas Nair. > > > Bugs: HIVE-5472 > https://issues.apache.org/jira/browse/HIVE-5472 > > > Repository: hive-git > > > Description > ------- > > Add current_date/current_timestamp. The UDFs get the current_date/timestamp > from the SessionState. > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 66f436b > ql/src/java/org/apache/hadoop/hive/ql/Driver.java ef6db3a > ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 23d77ca > ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g f412010 > ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g c960a6b > ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java c315985 > > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFCurrentDate.java > PRE-CREATION > > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFCurrentTimestamp.java > PRE-CREATION > ql/src/test/queries/clientpositive/current_date_timestamp.q PRE-CREATION > ql/src/test/results/clientpositive/current_date_timestamp.q.out > PRE-CREATION > ql/src/test/results/clientpositive/show_functions.q.out 36c8743 > > Diff: https://reviews.apache.org/r/29900/diff/ > > > Testing > ------- > > qfile test added > > > Thanks, > > Jason Dere > >
