-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29900/#review70130
-----------------------------------------------------------



ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFCurrentDate.java
<https://reviews.apache.org/r/29900/#comment115137>

    you can remove " = null". Class attributes in java are null by default


- Alexander Pivovarov


On Jan. 28, 2015, 11:22 p.m., Jason Dere wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29900/
> -----------------------------------------------------------
> 
> (Updated Jan. 28, 2015, 11:22 p.m.)
> 
> 
> Review request for hive and Thejas Nair.
> 
> 
> Bugs: HIVE-5472
>     https://issues.apache.org/jira/browse/HIVE-5472
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Add current_date/current_timestamp. The UDFs get the current_date/timestamp 
> from the SessionState.
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 66f436b 
>   ql/src/java/org/apache/hadoop/hive/ql/Driver.java ef6db3a 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 23d77ca 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g f412010 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g c960a6b 
>   ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java c315985 
>   
> ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFCurrentDate.java 
> PRE-CREATION 
>   
> ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFCurrentTimestamp.java
>  PRE-CREATION 
>   ql/src/test/queries/clientpositive/current_date_timestamp.q PRE-CREATION 
>   ql/src/test/results/clientpositive/current_date_timestamp.q.out 
> PRE-CREATION 
>   ql/src/test/results/clientpositive/show_functions.q.out 36c8743 
> 
> Diff: https://reviews.apache.org/r/29900/diff/
> 
> 
> Testing
> -------
> 
> qfile test added
> 
> 
> Thanks,
> 
> Jason Dere
> 
>

Reply via email to