-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32966/#review79344
-----------------------------------------------------------



ql/src/java/org/apache/hadoop/hive/ql/session/DependencyResolver.java
<https://reviews.apache.org/r/32966/#comment128610>

    You would reach here only if both ivysettings.xml and 
defaultGrapeConfig.xml are missing. Should the message indicate that as well?



ql/src/java/org/apache/hadoop/hive/ql/session/DependencyResolver.java
<https://reviews.apache.org/r/32966/#comment128608>

    Seems like this should be something more severe than just an INFO. A WARN 
maybe?


- Swarnim Kulkarni


On April 8, 2015, 7:13 a.m., Anant  Nag wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32966/
> -----------------------------------------------------------
> 
> (Updated April 8, 2015, 7:13 a.m.)
> 
> 
> Review request for hive.
> 
> 
> Bugs: HIVE-10251
>     https://issues.apache.org/jira/browse/HIVE-10251
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> * DependencyResolver is now not initialized in constructor. 
> * Changed all methods of DependencyResolver to static and added static 
> initialization block 
> * Added additional checks for ivysettings.xml file. If it is not found in 
> classpath then defaultGrapeConfig.xml is used instead.
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/session/DependencyResolver.java 
> 27bf3e46291e02bd689d7f3ac2cb5e71a18c8b2b 
>   ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 
> 66cff87d118ee22f2e8308b0b5c70f87d99d5625 
> 
> Diff: https://reviews.apache.org/r/32966/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Anant  Nag
> 
>

Reply via email to