----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32966/#review79475 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/session/DependencyResolver.java <https://reviews.apache.org/r/32966/#comment128883> This class would be used only when someone is trying to add jar from repository. Also other methods of this class depend upon the existence of ivysettings.xml file. So I think we should have this message here if ivysettings is not found. ql/src/java/org/apache/hadoop/hive/ql/session/DependencyResolver.java <https://reviews.apache.org/r/32966/#comment128885> Sure. I'll include it in the message. ql/src/java/org/apache/hadoop/hive/ql/session/DependencyResolver.java <https://reviews.apache.org/r/32966/#comment128884> Sure. I'll change it. ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java <https://reviews.apache.org/r/32966/#comment128882> I changed the methods to static to initialize the class only when it is required by the add jar feature and not initialize every time this feature is used. I think changing it to a singleton class would be a better option than making methods static. I'll do that. - Anant Nag On April 8, 2015, 7:13 a.m., Anant Nag wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32966/ > ----------------------------------------------------------- > > (Updated April 8, 2015, 7:13 a.m.) > > > Review request for hive. > > > Bugs: HIVE-10251 > https://issues.apache.org/jira/browse/HIVE-10251 > > > Repository: hive-git > > > Description > ------- > > * DependencyResolver is now not initialized in constructor. > * Changed all methods of DependencyResolver to static and added static > initialization block > * Added additional checks for ivysettings.xml file. If it is not found in > classpath then defaultGrapeConfig.xml is used instead. > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/session/DependencyResolver.java > 27bf3e46291e02bd689d7f3ac2cb5e71a18c8b2b > ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java > 66cff87d118ee22f2e8308b0b5c70f87d99d5625 > > Diff: https://reviews.apache.org/r/32966/diff/ > > > Testing > ------- > > > Thanks, > > Anant Nag > >
