----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34385/#review84408 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizationContext.java <https://reviews.apache.org/r/34385/#comment135639> This is exactly what has been done. See previous change. Sometimes RB can be confusing, in such cases I read patch text file. ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizationContext.java <https://reviews.apache.org/r/34385/#comment135641> Ok, will update the exception message. - Ashutosh Chauhan On May 19, 2015, 9:14 p.m., Ashutosh Chauhan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34385/ > ----------------------------------------------------------- > > (Updated May 19, 2015, 9:14 p.m.) > > > Review request for hive and Gopal V. > > > Bugs: HIVE-10745 > https://issues.apache.org/jira/browse/HIVE-10745 > > > Repository: hive-git > > > Description > ------- > > Better null handling by Vectorizer > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/exec/ExprNodeEvaluatorFactory.java > f08321c > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizationContext.java > 48f34a9 > > Diff: https://reviews.apache.org/r/34385/diff/ > > > Testing > ------- > > > Thanks, > > Ashutosh Chauhan > >
